X Tutup
Skip to content

In case phoenix.baseUrl is configured a menu entry will appear#37083

Merged
DeepDiver1975 merged 1 commit intomasterfrom
feature/add-phoenix-to-meu
Mar 26, 2020
Merged

In case phoenix.baseUrl is configured a menu entry will appear#37083
DeepDiver1975 merged 1 commit intomasterfrom
feature/add-phoenix-to-meu

Conversation

@DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented Mar 5, 2020 •
edited
Loading

Description

How Has This Been Tested?

  • ✋

Screenshots (if appropriate):

Screenshot from 2020-03-05 15-17-18

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

ToDo

  • add svg to be used for phoenix

@DeepDiver1975 DeepDiver1975 self-assigned this Mar 5, 2020
@DeepDiver1975 DeepDiver1975 force-pushed the feature/add-phoenix-to-meu branch from a4fbee0 to 4af61e1 Compare March 5, 2020 14:28
@owncloud owncloud deleted a comment from update-docs bot Mar 5, 2020
@PVince81 PVince81 requested a review from micbar March 5, 2020 14:40
@codecov
Copy link

codecov bot commented Mar 5, 2020 •
edited
Loading

Codecov Report

Merging #37083 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #37083      +/-   ##
============================================
- Coverage     64.76%   64.75%   -0.01%     
- Complexity    19136    19137       +1     
============================================
  Files          1270     1270              
  Lines         74915    74925      +10     
  Branches       1328     1328              
============================================
+ Hits          48517    48521       +4     
- Misses        26008    26014       +6     
  Partials        390      390
Flag Coverage Δ Complexity Δ
#javascript 54.18% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.93% <41.66%> (-0.01%) 19137.00 <0.00> (+1.00) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d64902c...4af61e1. Read the comment docs.

@PVince81 PVince81 self-assigned this Mar 16, 2020
@PVince81
Copy link
Contributor

PVince81 commented Mar 25, 2020

Let's merge this first. At least the icon is there to return to Phoenix.
We can adjust the name and icon once we have it.

@micbar @LukasHirt

@LukasHirt
Copy link
Collaborator

LukasHirt commented Mar 25, 2020

Let's merge this first. At least the icon is there to return to Phoenix.
We can adjust the name and icon once we have it.

Sounds good to me 👍

@DeepDiver1975 DeepDiver1975 marked this pull request as ready for review March 26, 2020 07:51
@DeepDiver1975 DeepDiver1975 merged commit 9d30462 into master Mar 26, 2020
@delete-merged-branch delete-merged-branch bot deleted the feature/add-phoenix-to-meu branch March 26, 2020 07:51
@davitol davitol mentioned this pull request Mar 31, 2020
Closed
43 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@micbar micbar Awaiting requested review from micbar

Assignees

@PVince81 PVince81

@DeepDiver1975 DeepDiver1975

Labels

3 - To Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DeepDiver1975 @PVince81 @LukasHirt
X Tutup