X Tutup
Skip to content

Harden cache control headers#37082

Merged
DeepDiver1975 merged 1 commit intomasterfrom
bugfix/cache-control-headers-hardening
Mar 5, 2020
Merged

Harden cache control headers#37082
DeepDiver1975 merged 1 commit intomasterfrom
bugfix/cache-control-headers-hardening

Conversation

@DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented Mar 5, 2020

Description

Related Issue

  • Fixes <issue_link>

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@update-docs
Copy link

update-docs bot commented Mar 5, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@DeepDiver1975 DeepDiver1975 force-pushed the bugfix/cache-control-headers-hardening branch from 4ad3989 to 799a8e9 Compare March 5, 2020 13:07
@codecov
Copy link

codecov bot commented Mar 5, 2020 •
edited
Loading

Codecov Report

Merging #37082 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #37082   +/-   ##
=========================================
  Coverage     64.76%   64.76%           
  Complexity    19136    19136           
=========================================
  Files          1270     1270           
  Lines         74915    74915           
  Branches       1328     1328           
=========================================
  Hits          48517    48517           
  Misses        26008    26008           
  Partials        390      390
Flag Coverage Δ Complexity Δ
#javascript 54.18% <ø> (ø) 0.00 <ø> (ø)
#phpunit 65.93% <0.00%> (ø) 19136.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d64902c...028ffb3. Read the comment docs.

@DeepDiver1975 DeepDiver1975 self-assigned this Mar 5, 2020
@DeepDiver1975 DeepDiver1975 requested a review from C0rby March 5, 2020 14:25
@DeepDiver1975 DeepDiver1975 marked this pull request as ready for review March 5, 2020 14:26
@DeepDiver1975 DeepDiver1975 force-pushed the bugfix/cache-control-headers-hardening branch from 799a8e9 to 028ffb3 Compare March 5, 2020 14:31
C0rby
C0rby approved these changes Mar 5, 2020
View reviewed changes
Copy link
Contributor

@C0rby C0rby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@DeepDiver1975 DeepDiver1975 merged commit 028e034 into master Mar 5, 2020
@delete-merged-branch delete-merged-branch bot deleted the bugfix/cache-control-headers-hardening branch March 5, 2020 16:55
@davitol davitol mentioned this pull request Mar 31, 2020
Closed
43 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@C0rby C0rby C0rby approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@DeepDiver1975 DeepDiver1975

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DeepDiver1975 @C0rby
X Tutup