Conversation
Contributor
Author
|
@micbar please allocate an appropriate person to review - there is just 1 line of code to change @individual-it please review the test changes |
Codecov Report
@@ Coverage Diff @@
## master #36878 +/- ##
============================================
+ Coverage 64.37% 64.66% +0.28%
- Complexity 19132 19137 +5
============================================
Files 1270 1270
Lines 74838 74888 +50
Branches 1329 1329
============================================
+ Hits 48176 48424 +248
+ Misses 26271 26073 -198
Partials 391 391
Continue to review full report at Codecov.
|
micbar
approved these changes
Feb 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If a user had a UID like
NewUserthen to get their own user information using the provisioning API, they had to specify exactlyNewUserin the URL of the request. That is a bit tricky for any client that tries to use this provisioning API endpoint - they have to know exact the case of the UID.The admin can do the same request and it is not case sensitive.
See the issue for more detail.
Compare the request UID with the actual internal UID in a case-insensitive manner when checking if the request is for the currently-authenticated user.
Related Issue
How Has This Been Tested?
Local runs of the adjusted acceptance tests.
Types of changes
Checklist: