X Tutup
Skip to content

Fix translation for the personal sharing text#36875

Merged
sharidas merged 1 commit intomasterfrom
fix-translation-personal-sharing
Feb 4, 2020
Merged

Fix translation for the personal sharing text#36875
sharidas merged 1 commit intomasterfrom
fix-translation-personal-sharing

Conversation

@sharidas
Copy link
Contributor

@sharidas sharidas commented Feb 4, 2020

Fix translation for personal sharing text.

Signed-off-by: Sujith H sharidasan@owncloud.com

Description

Add tranlsation for the text in Persnoal->Sharing page.

Related Issue

Motivation and Context

How Has This Been Tested?

  • This requires transifex to run for testing.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@sharidas
Fix translation for the personal sharing text
e0f22ab 
Fix translation for personal sharing text.

Signed-off-by: Sujith H <sharidasan@owncloud.com>
@sharidas sharidas force-pushed the fix-translation-personal-sharing branch from 15d734d to e0f22ab Compare February 4, 2020 06:47
@sharidas sharidas self-assigned this Feb 4, 2020
@sharidas sharidas added this to the development milestone Feb 4, 2020
@phil-davis
Copy link
Contributor

phil-davis commented Feb 4, 2020

Some drone pipelines had hung (phpunit running for >2 hours)
I restarted it.

@codecov
Copy link

codecov bot commented Feb 4, 2020

Codecov Report

Merging #36875 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #36875      +/-   ##
============================================
+ Coverage      64.7%   64.71%   +<.01%     
- Complexity    19130    19132       +2     
============================================
  Files          1270     1270              
  Lines         74868    74873       +5     
  Branches       1329     1329              
============================================
+ Hits          48444    48452       +8     
+ Misses        26033    26030       -3     
  Partials        391      391
Flag Coverage Δ Complexity Δ
#javascript 54.17% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.7% <100%> (-0.17%) 19132 <1> (+2)
Impacted Files Coverage Δ Complexity Δ
...iles_sharing/lib/Panels/Personal/PersonalPanel.php 100% <100%> (ø) 9 <1> (+2) ⬆️
apps/files_external/lib/Lib/Storage/SFTP.php 57.48% <0%> (ø) 0% <0%> (ø) ⬇️
lib/private/Files/Storage/DAV.php 79.09% <0%> (+0.61%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca213b2...e0f22ab. Read the comment docs.

@sharidas sharidas merged commit 11af391 into master Feb 4, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix-translation-personal-sharing branch February 4, 2020 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DeepDiver1975 DeepDiver1975 DeepDiver1975 approved these changes

Assignees

@sharidas sharidas

Labels

4 - To release

Projects

None yet

Milestone

development

Development

Successfully merging this pull request may close these issues.

[files_sharing] Settings text cannot be translated

3 participants

@sharidas @phil-davis @DeepDiver1975
X Tutup