Closed
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
phil-davis
reviewed
Jan 24, 2020
Contributor
phil-davis
left a comment
phil-davis
left a comment
There was a problem hiding this comment.
I made some comments on the words for the Gherkin steps.
| } | ||
|
|
||
| /** | ||
| * @When user :user gets size of file :resource using the WebDAV API |
Contributor
There was a problem hiding this comment.
Suggested change
| * @When user :user gets size of file :resource using the WebDAV API | |
| * @When user :user gets the size of file :resource using the WebDAV API |
|
|
||
| Scenario: Get the size of a file | ||
| When user "user0" gets size of file "textfile0.txt" using the WebDAV API | ||
| And the HTTP status code should be "207" |
Contributor
There was a problem hiding this comment.
Suggested change
| And the HTTP status code should be "207" | |
| Then the HTTP status code should be "207" |
| Scenario: Get the size of a file | ||
| When user "user0" gets size of file "textfile0.txt" using the WebDAV API | ||
| And the HTTP status code should be "207" | ||
| Then the size of file should be "26" |
Contributor
There was a problem hiding this comment.
Suggested change
| Then the size of file should be "26" | |
| And the size of file should be "26" |
| } | ||
|
|
||
| /** | ||
| * @Then the size of file should be :size |
Contributor
There was a problem hiding this comment.
Suggested change
| * @Then the size of file should be :size | |
| * @Then the size of the file should be :size |
| Then the value of the item "//s:message" in the response should be "" | ||
| And the HTTP status code should be "404" | ||
|
|
||
| Scenario: get the size of public link share |
Contributor
There was a problem hiding this comment.
Suggested change
| Scenario: get the size of public link share | |
| Scenario: get the size of a file shared by public link |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: