X Tutup
Skip to content

Fix the width of some confirmation buttons#36807

Merged
phil-davis merged 1 commit intomasterfrom
fix-button-width
Jan 24, 2020
Merged

Fix the width of some confirmation buttons#36807
phil-davis merged 1 commit intomasterfrom
fix-button-width

Conversation

@ChrisEdS
Copy link

@ChrisEdS ChrisEdS commented Jan 22, 2020

Description

Some buttons need the width property to react correctly.

Motivation and Context

I noticed that some input buttons are too short, actually as long as the text. This often looks unattractive. By setting the width this is fixed.

How Has This Been Tested?

Manual tested

Screenshots (if appropriate):

Before After
Screenshot 2020-01-22 at 13 40 25 1 Screenshot 2020-01-22 at 13 50 36

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@ChrisEdS ChrisEdS self-assigned this Jan 22, 2020
@ChrisEdS ChrisEdS added this to the development milestone Jan 22, 2020
@ChrisEdS ChrisEdS requested a review from phil-davis January 22, 2020 13:11
phil-davis
phil-davis reviewed Jan 22, 2020
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable.
Needs a changelog entry.
I added one.

@codecov
Copy link

codecov bot commented Jan 22, 2020 •
edited
Loading

Codecov Report

Merging #36807 into master will increase coverage by 0.59%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #36807      +/-   ##
============================================
+ Coverage     64.09%   64.69%   +0.59%     
- Complexity    19113    19114       +1     
============================================
  Files          1269     1269              
  Lines         74771    74808      +37     
  Branches       1327     1327              
============================================
+ Hits          47927    48395     +468     
+ Misses        26453    26022     -431     
  Partials        391      391
Flag Coverage Δ Complexity Δ
#javascript 54.1% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.86% <ø> (+0.65%) 19114 <ø> (+1) ⬆️
Impacted Files Coverage Δ Complexity Δ
apps/files/lib/Command/Scan.php 71.92% <0%> (-9.75%) 61% <0%> (ø)
lib/private/Files/Cache/HomePropagator.php 77.77% <0%> (-9.73%) 3% <0%> (ø)
apps/dav/lib/CalDAV/CalDavBackend.php 80.57% <0%> (+0.13%) 169% <0%> (ø) ⬇️
apps/dav/lib/CardDAV/CardDavBackend.php 82.53% <0%> (+0.22%) 85% <0%> (ø) ⬇️
lib/private/Files/View.php 84.83% <0%> (+0.29%) 389% <0%> (ø) ⬇️
apps/dav/lib/Connector/Sabre/File.php 84.19% <0%> (+0.64%) 115% <0%> (ø) ⬇️
lib/private/DB/Connection.php 67.64% <0%> (+0.73%) 49% <0%> (ø) ⬇️
lib/private/DB/QueryBuilder/QueryBuilder.php 91.34% <0%> (+0.96%) 68% <0%> (ø) ⬇️
lib/private/DB/MDB2SchemaWriter.php 94.79% <0%> (+1.04%) 34% <0%> (ø) ⬇️
lib/private/legacy/db.php 71.79% <0%> (+1.28%) 33% <0%> (ø) ⬇️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3485d0...859952c. Read the comment docs.

@owncloud owncloud deleted a comment from update-docs bot Jan 24, 2020
@phil-davis
Copy link
Contributor

phil-davis commented Jan 24, 2020

Rebased again - there were stupid drone errors waiting for Oracle docker to download.

@phil-davis phil-davis self-assigned this Jan 24, 2020
@phil-davis phil-davis merged commit f15a795 into master Jan 24, 2020
@delete-merged-branch delete-merged-branch bot deleted the fix-button-width branch January 24, 2020 15:40
@phil-davis phil-davis mentioned this pull request Jan 28, 2020
Closed
@ChrisEdS ChrisEdS mentioned this pull request Feb 5, 2020
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phil-davis phil-davis phil-davis approved these changes

Assignees

@phil-davis phil-davis

@ChrisEdS ChrisEdS

Labels

4 - To release

Projects

None yet

Milestone

development

Development

Successfully merging this pull request may close these issues.

2 participants

@ChrisEdS @phil-davis
X Tutup