X Tutup
Skip to content

Run tests to support MariaDB:10.4#36800

Merged
micbar merged 1 commit intomasterfrom
mariadb10.4
Jan 27, 2020
Merged

Run tests to support MariaDB:10.4#36800
micbar merged 1 commit intomasterfrom
mariadb10.4

Conversation

@phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Jan 21, 2020

Description

Run a pipeline of unit tests on MariaDB:10.4

Note: #36798 demonstrates running a full set of acceptance tests on MariaDB:10.4

Related Issue

Motivation and Context

Support the current stable release of MariaDB

How Has This Been Tested?

CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:
  • Changelog item, see TEMPLATE

@phil-davis
Copy link
Contributor Author

Note: we currently happen to run the acceptance tests with MariaDB:10.2 as the backend database.
(it could well have been any MariaDB version, or MySQL, PostgreSQL or Oracle)
There are too many acceptance tests to be running them all with all databases on every PR!
Should we switch from MariaDB:10.2 to MariaDB:10.4 for the acceptance tests?
Or is it better to be running an "older" version of MariaDB?

@phil-davis
Copy link
Contributor Author

Anyone please comment, specially if you think there is something extra that should be done to verify support for MariaDB:10.4

@codecov
Copy link

codecov bot commented Jan 22, 2020

Codecov Report

Merging #36800 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #36800   +/-   ##
=========================================
  Coverage     64.68%   64.68%           
  Complexity    19121    19121           
=========================================
  Files          1269     1269           
  Lines         74778    74778           
  Branches       1320     1320           
=========================================
  Hits          48372    48372           
  Misses        26018    26018           
  Partials        388      388
Flag Coverage Δ Complexity Δ
#javascript 54.12% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.85% <ø> (ø) 19121 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8eb5c88...0689f61. Read the comment docs.

@micbar
Copy link
Contributor

micbar commented Jan 22, 2020

@phil-davis Thank you for testing this.
IMO this is sufficient for now.
We should run our acceptance tests on mariadb 10.2 and switch to mariadb 10.3 when the LTS distros are using it.

According to the web, Ubuntu 20.04 Focal will have mariadb 10.3

@DeepDiver1975 @felixboehm @pmaier1 Any opinions?

@phil-davis
Copy link
Contributor Author

@DeepDiver1975 @felixboehm @pmaier1 ping - Any opinions?
Is this OK to merge (and thus officially support MariaDb:10.4 with ownCloud 10.4 release)?

@phil-davis
Copy link
Contributor Author

Added some people as reviewers - that might get them to notice this PR and comment.

@micbar micbar merged commit 97c10cb into master Jan 27, 2020
@delete-merged-branch delete-merged-branch bot deleted the mariadb10.4 branch January 27, 2020 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

X Tutup