Change Error to Other on settingsPage#36776
Merged
phil-davis merged 1 commit intomasterfrom Jan 20, 2020
Merged
Conversation
Contributor
|
Isn't this the same as #36775 but with other wording? |
Codecov Report
@@ Coverage Diff @@
## master #36776 +/- ##
=========================================
Coverage 64.68% 64.68%
Complexity 19121 19121
=========================================
Files 1269 1269
Lines 74778 74778
Branches 1320 1320
=========================================
Hits 48372 48372
Misses 26018 26018
Partials 388 388
Continue to review full report at Codecov.
|
Contributor
Author
yes, the "advantage" is that the word "Other" is already used elsewhere and exists in translations. So there is no need to wait for people to do translations on Transifex. It's just my idea of a way to be able to "fix" this without the hassle of having to update all the translations. |
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If we change
ErrortoOther(which is already a translated string) then we avoid the translation problem. IMO "Other" is an OK title for this "Additional" settings page when it is empty.Related Issue
Motivation and Context
Confusion should be avoided.
How Has This Been Tested?
Manual
Types of changes
Checklist: