Do not dispatch event for non existing shares#36759
Merged
Conversation
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
VicDeo
changed the title
Codecov Report
@@ Coverage Diff @@
## master #36759 +/- ##
============================================
+ Coverage 64.68% 64.68% +<.01%
- Complexity 19120 19121 +1
============================================
Files 1269 1269
Lines 74778 74779 +1
Branches 1320 1320
============================================
+ Hits 48372 48373 +1
Misses 26018 26018
Partials 388 388
Continue to review full report at Codecov.
|
VicDeo
force-pushed
the
bugfix/decline-found-shares-only
branch
3 times, most recently
from
9d515ec to
eb653ab
Compare
VicDeo
force-pushed
the
bugfix/decline-found-shares-only
branch
from
eb653ab to
741d0aa
Compare
VicDeo
changed the title
micbar
approved these changes
Jan 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fetchreturnsfalsewhen the share does not existwe don't need to dispatch the Decline event on
falseMotivation and Context
it causes sending a decline request to an empty remote server:
federatedfilesharing/lib/AppInfo/Application.php(268): OCA\FederatedFileSharing\Notifications->sendDeclineShare(NULL, NULL, NULL)How Has This Been Tested?
An unit test.
The way of reproduction IRL is unclear.
Types of changes
Checklist: