X Tutup
Skip to content

Bump handlebars from 4.1.2 to 4.5.3 in /build#36438

Merged
micbar merged 1 commit intomasterfrom
dependabot/npm_and_yarn/build/handlebars-4.5.3
Dec 20, 2019
Merged

Bump handlebars from 4.1.2 to 4.5.3 in /build#36438
micbar merged 1 commit intomasterfrom
dependabot/npm_and_yarn/build/handlebars-4.5.3

Conversation

@dependabot-preview
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Nov 18, 2019

Bumps handlebars from 4.1.2 to 4.5.3.

Changelog

Sourced from handlebars's changelog.

v4.5.3 - November 18th, 2019

Bugfixes:

  • fix: add "no-prototype-builtins" eslint-rule and fix all occurences - f7f05d7
  • fix: add more properties required to be enumerable - 1988878

Chores / Build:

  • fix: use !== 0 instead of != 0 - c02b05f
  • add chai and dirty-chai and sinon, for cleaner test-assertions and spies,
    deprecate old assertion-methods - 93e284e, 886ba86, 0817dad, 93516a0

Security:

  • The properties __proto__, __defineGetter__, __defineSetter__ and __lookupGetter__
    have been added to the list of "properties that must be enumerable".
    If a property by that name is found and not enumerable on its parent,
    it will silently evaluate to undefined. This is done in both the compiled template and the "lookup"-helper.
    This will prevent new Remote-Code-Execution exploits that have been
    published recently.

Compatibility notes:

  • Due to the security-fixes. The semantics of the templates using
    __proto__, __defineGetter__, __defineSetter__ and __lookupGetter__ in the respect that those expression now return
    undefined rather than their actual value from the proto.
  • The semantics have not changed in cases where the properties are enumerable, as in:
{
  __proto__: 'some string'
}
  • The change may be breaking in that respect, but we still only
    increase the patch-version, because the incompatible use-cases
    are not intended, undocumented and far less important than fixing
    Remote-Code-Execution exploits on existing systems.

Commits

v4.5.2 - November 13th, 2019

Bugfixes

  • fix: use String(field) in lookup when checking for "constructor" - d541378
  • test: add fluent API for testing Handlebars - c2ac79c

Compatibility notes:

  • no incompatibility are to be expected
... (truncated)
Commits
  • c819c8b v4.5.3
  • 827c9d0 Update release notes
  • f7f05d7 fix: add "no-prototype-builtins" eslint-rule and fix all occurences
  • 1988878 fix: add more properties required to be enumerable
  • 886ba86 test/chore: add chai/expect and sinon to "runtime"-environment
  • 0817dad test: add sinon as global variable to eslint in the specs
  • 93516a0 test: add sinon.js for spies, deprecate current assertions
  • 93e284e chore: add chai and dirty-chai for better test assertions
  • c02b05f fix: use !== 0 instead of != 0
  • 8de121d v4.5.2
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@phil-davis
Copy link
Contributor

@dependabot rebase

@phil-davis
Copy link
Contributor

The first run of drone CI had "dumb" clone errors

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/build/handlebars-4.5.3 branch from 285c072 to d6b33d9 Compare November 20, 2019 15:28
@codecov
Copy link

codecov bot commented Nov 20, 2019

Codecov Report

Merging #36438 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master   #36438   +/-   ##
=========================================
  Coverage     64.68%   64.68%           
  Complexity    19105    19105           
=========================================
  Files          1269     1269           
  Lines         74721    74721           
  Branches       1320     1320           
=========================================
  Hits          48333    48333           
  Misses        26000    26000           
  Partials        388      388
Flag Coverage Δ Complexity Δ
#javascript 54.12% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.85% <ø> (ø) 19105 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4273a81...06c0140. Read the comment docs.

@phil-davis
Copy link
Contributor

@dependabot rebase

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/build/handlebars-4.5.3 branch from d6b33d9 to ef5aa68 Compare December 20, 2019 01:34
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/build/handlebars-4.5.3 branch from ef5aa68 to 06c0140 Compare December 20, 2019 15:00
@phil-davis
Copy link
Contributor

@micbar I guess this should also be merged?

@micbar micbar merged commit 484d242 into master Dec 20, 2019
@delete-merged-branch delete-merged-branch bot deleted the dependabot/npm_and_yarn/build/handlebars-4.5.3 branch December 20, 2019 19:53
@micbar
Copy link
Contributor

micbar commented Dec 20, 2019

@phil-davis Changelog merged b711e71

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

X Tutup