Conversation
Codecov Report
@@ Coverage Diff @@
## master #36297 +/- ##
============================================
+ Coverage 64.86% 64.86% +<.01%
- Complexity 19775 19782 +7
============================================
Files 1271 1271
Lines 74705 74713 +8
Branches 1309 1309
============================================
+ Hits 48455 48464 +9
+ Misses 25864 25863 -1
Partials 386 386
Continue to review full report at Codecov.
|
VicDeo
force-pushed
the
fix/36241
branch
2 times, most recently
from
b0aaeb2 to
c1b6097
Compare
micbar
reviewed
Oct 22, 2019
VicDeo
changed the title
VicDeo
force-pushed
the
fix/36241
branch
4 times, most recently
from
bc43d08 to
2dfb528
Compare
Contributor
|
merged into #36337. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove share permission for
share_folderRelated Issue
Motivation and Context
It doesn't allow sharing the entire
share_folderto other users/groupsHow Has This Been Tested?
Actual result
share_folder can be shared. Any new files which are added to that folder as newly received shares are not shared to the collaborators. But new files can be added via public links.
Expected result
Sharing of share_folder is not allowed
Types of changes
Checklist: