X Tutup
Skip to content

[release-10.3.0] Make sure to parse only if attributes are json string in reshare#36214

Merged
micbar merged 1 commit intorelease-10.3.0from
share_item_model_reshare_fix-10.3.0
Sep 24, 2019
Merged

[release-10.3.0] Make sure to parse only if attributes are json string in reshare#36214
micbar merged 1 commit intorelease-10.3.0from
share_item_model_reshare_fix-10.3.0

Conversation

@phil-davis
Copy link
Contributor

cherry-pick of PR #36207 to release-10.3.0 branch.

If it is wanted for 10.3.0 release.

@codecov
Copy link

codecov bot commented Sep 24, 2019

Codecov Report

Merging #36214 into release-10.3.0 will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-10.3.0   #36214   +/-   ##
===============================================
  Coverage              54%      54%           
===============================================
  Files                  63       63           
  Lines                7408     7408           
  Branches             1309     1309           
===============================================
  Hits                 4001     4001           
  Misses               3021     3021           
  Partials              386      386
Flag Coverage Δ
#javascript 54% <100%> (ø) ⬆️
Impacted Files Coverage Δ
core/js/shareitemmodel.js 80.59% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0ac6b8...2c74c27. Read the comment docs.

@mrow4a
Copy link
Contributor

mrow4a commented Sep 24, 2019

@micbar @PVince81 shall we?

@micbar micbar merged commit b7ab2c9 into release-10.3.0 Sep 24, 2019
@delete-merged-branch delete-merged-branch bot deleted the share_item_model_reshare_fix-10.3.0 branch September 24, 2019 11:54
@micbar micbar mentioned this pull request Sep 25, 2019
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

X Tutup