X Tutup
Skip to content

Remove swift primary and secondary storage support#35951

Merged
DeepDiver1975 merged 2 commits intomasterfrom
feature/kill-swift-secondary-storage
Aug 2, 2019
Merged

Remove swift primary and secondary storage support#35951
DeepDiver1975 merged 2 commits intomasterfrom
feature/kill-swift-secondary-storage

Conversation

@DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented Jul 30, 2019 •
edited
Loading

Description

Swift primary storage was deprecated in 10.0.9 - we are now fully killing it - primary as well as secondary.
https://doc.owncloud.com/server/10.2/admin_manual/release_notes.html#swift-objectstore-deprecation

Related Issue

#27049

How Has This Been Tested?

  • 🤖

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@DeepDiver1975 DeepDiver1975 self-assigned this Jul 30, 2019
@patrickjahns
Copy link
Contributor

patrickjahns commented Jul 30, 2019

@DeepDiver1975
Drone has some swift jobs - also drop the from .drone.yml that should get us green then

@patrickjahns
Copy link
Contributor

patrickjahns commented Jul 30, 2019

Example https://github.com/owncloud/core/blob/master/.drone.yml#L807-L813

@DeepDiver1975 DeepDiver1975 changed the title Remove swift secondary storage support Remove swift primary and secondary storage support Jul 30, 2019
patrickjahns
patrickjahns approved these changes Jul 30, 2019
View reviewed changes
Copy link
Contributor

@patrickjahns patrickjahns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code refactoring LGTM

pmaier1
pmaier1 approved these changes Jul 30, 2019
View reviewed changes
Copy link
Contributor

@pmaier1 pmaier1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed. This needs a mention in the release notes!

@DeepDiver1975 DeepDiver1975 force-pushed the feature/kill-swift-secondary-storage branch from d20c3de to fedfcb4 Compare August 2, 2019 06:23
@codecov
Copy link

codecov bot commented Aug 2, 2019

Codecov Report

Merging #35951 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #35951      +/-   ##
============================================
+ Coverage     65.39%   65.45%   +0.05%     
+ Complexity    20197    20181      -16     
============================================
  Files          1299     1296       -3     
  Lines         76762    76367     -395     
  Branches       1301     1301              
============================================
- Hits          50202    49984     -218     
+ Misses        26175    25998     -177     
  Partials        385      385
Flag Coverage Δ Complexity Δ
#javascript 53.85% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.69% <ø> (+0.06%) 20181 <ø> (-16) ⬇️
Impacted Files Coverage Δ Complexity Δ
apps/files_external/lib/AppInfo/Application.php 0% <ø> (ø) 0 <0> (ø) ⬇️
lib/private/Helper/LocaleHelper.php 100% <0%> (+2.63%) 15% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c570322...fedfcb4. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Aug 2, 2019

Codecov Report

Merging #35951 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #35951      +/-   ##
============================================
+ Coverage     65.39%   65.45%   +0.05%     
+ Complexity    20197    20181      -16     
============================================
  Files          1299     1296       -3     
  Lines         76762    76367     -395     
  Branches       1301     1301              
============================================
- Hits          50202    49984     -218     
+ Misses        26175    25998     -177     
  Partials        385      385
Flag Coverage Δ Complexity Δ
#javascript 53.85% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.69% <ø> (+0.06%) 20181 <ø> (-16) ⬇️
Impacted Files Coverage Δ Complexity Δ
apps/files_external/lib/AppInfo/Application.php 0% <ø> (ø) 0 <0> (ø) ⬇️
lib/private/Helper/LocaleHelper.php 100% <0%> (+2.63%) 15% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c570322...fedfcb4. Read the comment docs.

@DeepDiver1975
Copy link
Member Author

DeepDiver1975 commented Aug 2, 2019

drone is only failing because of #35970 -> merge

@DeepDiver1975 DeepDiver1975 merged commit 5ca460b into master Aug 2, 2019
@delete-merged-branch delete-merged-branch bot deleted the feature/kill-swift-secondary-storage branch August 2, 2019 09:44
@davitol davitol mentioned this pull request Sep 3, 2019
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@felixboehm felixboehm Awaiting requested review from felixboehm

2 more reviewers

@patrickjahns patrickjahns patrickjahns approved these changes

@pmaier1 pmaier1 pmaier1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@DeepDiver1975 DeepDiver1975

Labels

3 - To Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DeepDiver1975 @patrickjahns @pmaier1 @phil-davis
X Tutup