X Tutup
Skip to content

Backport of Trigger dav events for the public.php/webdav endpoint#35820

Merged
micbar merged 1 commit intostable10from
public_dav_events-stable10
Jul 15, 2019
Merged

Backport of Trigger dav events for the public.php/webdav endpoint#35820
micbar merged 1 commit intostable10from
public_dav_events-stable10

Conversation

@sharidas
Copy link
Contributor

Trigger dav events for the public.php/webdav endpoint.
Populate the event args so that recipient of the event
could use them.

Signed-off-by: Sujith H sharidasan@owncloud.com

Description

Trigger events in order to know when the public.php/webdav endpoint is being accessed. The main goal for this is to know when a download through this public endpoint happens.
Note that these events aren't being listened by anyone for now.

Related Issue

Foundation to solve https://github.com/owncloud/admin_audit/issues/162

Motivation and Context

This will allow us to know when a file is being downloaded through the public.php/webdav endpoint, or when a file is being uploaded through the same endpoint (assuming enough permissions to do so)

How Has This Been Tested?

  • Manual modifications in the code to ensure the events are being triggered

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

Trigger dav events for the public.php/webdav endpoint.
Populate the event args so that recipient of the event
could use them.

Signed-off-by: Sujith H <sharidasan@owncloud.com>
@sharidas sharidas added this to the development milestone Jul 15, 2019
@sharidas sharidas requested a review from jvillafanez July 15, 2019 07:00
@sharidas sharidas self-assigned this Jul 15, 2019
@sharidas
Copy link
Contributor Author

Original PR: #35759

@codecov
Copy link

codecov bot commented Jul 15, 2019

Codecov Report

Merging #35820 into stable10 will increase coverage by 0.01%.
The diff coverage is 95.83%.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #35820      +/-   ##
==============================================
+ Coverage       65.09%   65.11%   +0.01%     
- Complexity      20239    20245       +6     
==============================================
  Files            1300     1301       +1     
  Lines           77238    77286      +48     
  Branches         1301     1301              
==============================================
+ Hits            50279    50325      +46     
- Misses          26574    26576       +2     
  Partials          385      385
Flag Coverage Δ Complexity Δ
#javascript 53.85% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.3% <95.83%> (+0.02%) 20245 <6> (+6) ⬆️
Impacted Files Coverage Δ Complexity Δ
apps/dav/appinfo/v1/publicwebdav.php 0% <0%> (ø) 0 <0> (ø) ⬇️
...s/dav/lib/Files/Sharing/PublicLinkEventsPlugin.php 100% <100%> (ø) 6 <6> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50df15a...1810404. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jul 15, 2019

Codecov Report

Merging #35820 into stable10 will increase coverage by 0.01%.
The diff coverage is 95.83%.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #35820      +/-   ##
==============================================
+ Coverage       65.09%   65.11%   +0.01%     
- Complexity      20239    20245       +6     
==============================================
  Files            1300     1301       +1     
  Lines           77238    77286      +48     
  Branches         1301     1301              
==============================================
+ Hits            50279    50325      +46     
- Misses          26574    26576       +2     
  Partials          385      385
Flag Coverage Δ Complexity Δ
#javascript 53.85% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.3% <95.83%> (+0.02%) 20245 <6> (+6) ⬆️
Impacted Files Coverage Δ Complexity Δ
apps/dav/appinfo/v1/publicwebdav.php 0% <0%> (ø) 0 <0> (ø) ⬇️
...s/dav/lib/Files/Sharing/PublicLinkEventsPlugin.php 100% <100%> (ø) 6 <6> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50df15a...1810404. Read the comment docs.

@micbar micbar merged commit 426de20 into stable10 Jul 15, 2019
@delete-merged-branch delete-merged-branch bot deleted the public_dav_events-stable10 branch July 15, 2019 09:23
@davitol davitol mentioned this pull request Sep 3, 2019
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

X Tutup