X Tutup
Skip to content

[stable10] Backport of Comment create event should have comment id#35799

Merged
phil-davis merged 1 commit intostable10from
add-commentId-to-event-stable10
Jul 10, 2019
Merged

[stable10] Backport of Comment create event should have comment id#35799
phil-davis merged 1 commit intostable10from
add-commentId-to-event-stable10

Conversation

@sharidas
Copy link
Contributor

@sharidas sharidas commented Jul 10, 2019

When a comment is created, the comment id should
be available in the symfony event.

Signed-off-by: Sujith H sharidasan@owncloud.com

Description

Add comment id along with the symfony event generated for the new comment created. This change is for consistency, as we have comment id for the udpate and delete change.

Related Issue

  • Fixes <issue_link>

Motivation and Context

For the sake of consistency add comment id to symfony event generated when a new comment is created.

How Has This Been Tested?

  • Tested using unit test.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@sharidas
[stable10] Backport of Comment create event should have comment id
b820d28 
When a comment is created, the comment id should
be available in the symfony event.

Signed-off-by: Sujith H <sharidasan@owncloud.com>
@sharidas sharidas self-assigned this Jul 10, 2019
@sharidas sharidas added this to the development milestone Jul 10, 2019
@sharidas
Copy link
Contributor Author

sharidas commented Jul 10, 2019

Original PR: #35793

@sharidas sharidas mentioned this pull request Jul 10, 2019
Merged
11 tasks
@sharidas
Copy link
Contributor Author

sharidas commented Jul 10, 2019

Note: Kindly do not merge this PR, because master branch PR is yet to be merged.

@phil-davis
Copy link
Contributor

phil-davis commented Jul 10, 2019

I merged master PR, so merging backport also.

@phil-davis phil-davis merged commit 79cd935 into stable10 Jul 10, 2019
@delete-merged-branch delete-merged-branch bot deleted the add-commentId-to-event-stable10 branch July 10, 2019 13:07
@davitol davitol mentioned this pull request Sep 3, 2019
Closed
13 tasks
@davitol
Copy link
Contributor

davitol commented Sep 23, 2019 •
edited
Loading

Is there a manual way to test this PR? Any steps to reproduce something? I think there isn't any related issue, but just to be sure.

@sharidas
Copy link
Contributor Author

sharidas commented Sep 23, 2019

Actually the easiest way would be to test it against the audit 2.0.0 branch.

@davitol
Copy link
Contributor

davitol commented Sep 23, 2019 •
edited
Loading

Tested with non-released admin_audit branch 2.0.0 + oC 10.3 alpha2.

Create a comment and check owncloud.log:

{"reqId":"NWHp2BwLzAXp1Q3EEGMP","level":0,"time":"2019-09-23T11:43:42+00:00","remoteAddr":"172.18.0.1","user":"admin","app":"admin_audit_raw","method":"POST","url":"\/remote.php\/dav\/comments\/files\/7\/","message":"user <admin>, displayName <admin> created comment for folder \"\/Photos\" with fileid: 7","action":"comment_created","fileId":"7","path":"\/Photos","commentId":"3","CLI":false,"userAgent":"Mozilla\/5.0 (Macintosh; Intel Mac OS X 10.13; rv:69.0) Gecko\/20100101 Firefox\/69.0","auditGroups":["admin"],"auditUsers":["admin"]}
{"reqId":"NWHp2BwLzAXp1Q3EEGMP","level":1,"time":"2019-09-23T11:43:42+00:00","remoteAddr":"172.18.0.1","user":"admin","app":"admin_audit","method":"POST","url":"\/remote.php\/dav\/comments\/files\/7\/","message":"user <admin>, displayName <admin> created comment for folder \"\/Photos\"","action":"comment_created","fileId":"7","path":"\/Photos","commentId":"3","CLI":false,"userAgent":"Mozilla\/5.0 (Macintosh; Intel Mac OS X 10.13; rv:69.0) Gecko\/20100101 Firefox\/69.0","auditGroups":["admin"],"auditUsers":["admin"],"actor":"user <admin>, displayName <admin>"}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phil-davis phil-davis Awaiting requested review from phil-davis

1 more reviewer

@karakayasemi karakayasemi karakayasemi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sharidas sharidas

Labels

3 - To Review

Projects

None yet

Milestone

development

Development

Successfully merging this pull request may close these issues.

5 participants

@sharidas @phil-davis @davitol @karakayasemi @patrickjahns
X Tutup