[stable10] Fix method signature of ExceptionLoggerPlugin::logException to allow …#35775
Merged
DeepDiver1975 merged 1 commit intostable10from Jul 8, 2019
Merged
Conversation
…Throwable as argument
5 tasks
Codecov Report
@@ Coverage Diff @@
## stable10 #35775 +/- ##
===========================================
Coverage 64.99% 64.99%
Complexity 20279 20279
===========================================
Files 1302 1302
Lines 77354 77354
Branches 1301 1301
===========================================
Hits 50274 50274
Misses 26695 26695
Partials 385 385
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## stable10 #35775 +/- ##
===========================================
Coverage 64.99% 64.99%
Complexity 20279 20279
===========================================
Files 1302 1302
Lines 77354 77354
Branches 1301 1301
===========================================
Hits 50274 50274
Misses 26695 26695
Partials 385 385
Continue to review full report at Codecov.
|
DeepDiver1975
approved these changes
Jul 8, 2019
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…Throwable as argument
Description
Backport the remaining commit from #32821
The code from the other commits is already in
stable10Related Issue
Motivation and Context
Get all the bits of code that were in PHP 7.3 support PRs in
masterand backport them tostable10How Has This Been Tested?
CI
Types of changes
Checklist: