Trigger dav events for the public.php/webdav endpoint#35759
Merged
DeepDiver1975 merged 4 commits intomasterfrom Jul 15, 2019
Merged
Trigger dav events for the public.php/webdav endpoint#35759DeepDiver1975 merged 4 commits intomasterfrom
DeepDiver1975 merged 4 commits intomasterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #35759 +/- ##
============================================
- Coverage 65.81% 65.76% -0.05%
- Complexity 18818 18824 +6
============================================
Files 1228 1229 +1
Lines 70982 71030 +48
Branches 1289 1289
============================================
Hits 46716 46716
- Misses 23888 23936 +48
Partials 378 378
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #35759 +/- ##
============================================
+ Coverage 65.81% 65.83% +0.01%
- Complexity 18818 18824 +6
============================================
Files 1228 1229 +1
Lines 70982 71024 +42
Branches 1289 1289
============================================
+ Hits 46716 46756 +40
- Misses 23888 23890 +2
Partials 378 378
Continue to review full report at Codecov.
|
sharidas
suggested changes
Jul 10, 2019
Contributor
sharidas
left a comment
sharidas
left a comment
There was a problem hiding this comment.
Kindly add php docs for the functions. Other wise it looks ok.
Add token to the event dispatched for the dav public link accessed. Signed-off-by: Sujith H <sharidasan@owncloud.com>
sharidas
force-pushed
the
public_dav_events
branch
from
9071640 to
e51d2fc
Compare
Contributor
|
DeepDiver1975
approved these changes
Jul 15, 2019
11 tasks
Contributor
|
Backport PR: #35820 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Trigger events in order to know when the public.php/webdav endpoint is being accessed. The main goal for this is to know when a download through this public endpoint happens.
Note that these events aren't being listened by anyone for now.
Related Issue
Foundation to solve https://github.com/owncloud/admin_audit/issues/162
Motivation and Context
This will allow us to know when a file is being downloaded through the public.php/webdav endpoint, or when a file is being uploaded through the same endpoint (assuming enough permissions to do so)
How Has This Been Tested?
Manual modifications in the code to ensure the events are being triggered
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: