[stable10] Remove $CLASSPATH and move autoloader to namespace#35755
Merged
DeepDiver1975 merged 3 commits intostable10from Jul 3, 2019
Merged
[stable10] Remove $CLASSPATH and move autoloader to namespace#35755DeepDiver1975 merged 3 commits intostable10from
DeepDiver1975 merged 3 commits intostable10from
Conversation
Contributor
Author
|
Note: this is on top of PR #35752 because that PR is also adjusting similar files in |
DeepDiver1975
approved these changes
Jul 3, 2019
Codecov Report
@@ Coverage Diff @@
## stable10 #35755 +/- ##
==============================================
+ Coverage 64.94% 64.94% +<.01%
+ Complexity 20267 20260 -7
==============================================
Files 1300 1300
Lines 77362 77346 -16
Branches 1301 1301
==============================================
- Hits 50241 50236 -5
+ Misses 26736 26725 -11
Partials 385 385
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## stable10 #35755 +/- ##
==============================================
+ Coverage 64.94% 64.94% +<.01%
+ Complexity 20267 20260 -7
==============================================
Files 1300 1300
Lines 77362 77346 -16
Branches 1301 1301
==============================================
- Hits 50241 50236 -5
+ Misses 26736 26725 -11
Partials 385 385
Continue to review full report at Codecov.
|
c4a434e to
28180d8
Compare
This was referenced Jul 4, 2019
10 tasks
13 tasks
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
#32203 Remove $CLASSPATH - this is no longer needed. Apps are using proper namespaces today.
#32204 move autoloader to namespace
These resolve the remaining real differences between
composer.jsoninmasterandstable0After this PR, the diff is just:
which is only that
stable10still supports PHP 7.0Motivation: get rid of more diffs between
masterandstable10