X Tutup
Skip to content

[stable10] Remove $CLASSPATH and move autoloader to namespace#35755

Merged
DeepDiver1975 merged 3 commits intostable10from
stable10-tech-dept/drop-CLASSPATH-support
Jul 3, 2019
Merged

[stable10] Remove $CLASSPATH and move autoloader to namespace#35755
DeepDiver1975 merged 3 commits intostable10from
stable10-tech-dept/drop-CLASSPATH-support

Conversation

@phil-davis
Copy link
Contributor

Backport
#32203 Remove $CLASSPATH - this is no longer needed. Apps are using proper namespaces today.
#32204 move autoloader to namespace

These resolve the remaining real differences between composer.json in master and stable0

After this PR, the diff is just:

diff --git a/composer.json b/composer.json
index 66190d3ba3..1948f7af74 100644
--- a/composer.json
+++ b/composer.json
@@ -7,7 +7,7 @@
         "optimize-autoloader": true,
         "classmap-authoritative": false,
         "platform": {
-            "php": "7.0.8"
+            "php": "7.1"
         }
     },
     "autoload" : {
@@ -30,7 +30,7 @@
         "roave/security-advisories": "dev-master"
     },
     "require": {
-        "php": ">=7.0.8",
+        "php": ">=7.1",
         "doctrine/dbal": "^2.5",
         "phpseclib/phpseclib": "^2.0",
         "rackspace/php-opencloud": "v1.9.2",

which is only that stable10 still supports PHP 7.0

Motivation: get rid of more diffs between master and stable10

@phil-davis phil-davis requested a review from DeepDiver1975 July 3, 2019 10:25
@phil-davis phil-davis self-assigned this Jul 3, 2019
@phil-davis
Copy link
Contributor Author

Note: this is on top of PR #35752 because that PR is also adjusting similar files in stable10 to match master

@codecov
Copy link

codecov bot commented Jul 3, 2019

Codecov Report

Merging #35755 into stable10 will increase coverage by <.01%.
The diff coverage is 11.76%.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #35755      +/-   ##
==============================================
+ Coverage       64.94%   64.94%   +<.01%     
+ Complexity      20267    20260       -7     
==============================================
  Files            1300     1300              
  Lines           77362    77346      -16     
  Branches         1301     1301              
==============================================
- Hits            50241    50236       -5     
+ Misses          26736    26725      -11     
  Partials          385      385
Flag Coverage Δ Complexity Δ
#javascript 53.85% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.11% <11.76%> (ø) 20260 <2> (-7) ⬇️
Impacted Files Coverage Δ Complexity Δ
apps/files_external/appinfo/app.php 0% <ø> (ø) 0 <0> (ø) ⬇️
index.php 0% <0%> (ø) 0 <0> (ø) ⬇️
lib/base.php 4.23% <0%> (+0.01%) 153 <0> (ø) ⬇️
console.php 0% <0%> (ø) 0 <0> (ø) ⬇️
lib/private/Autoloader.php 92.68% <100%> (ø) 20 <2> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d704115...c4a434e. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 3, 2019

Codecov Report

Merging #35755 into stable10 will increase coverage by <.01%.
The diff coverage is 28.57%.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #35755      +/-   ##
==============================================
+ Coverage       64.94%   64.94%   +<.01%     
+ Complexity      20267    20260       -7     
==============================================
  Files            1300     1300              
  Lines           77362    77346      -16     
  Branches         1301     1301              
==============================================
- Hits            50241    50236       -5     
+ Misses          26736    26725      -11     
  Partials          385      385
Flag Coverage Δ Complexity Δ
#javascript 53.85% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.11% <28.57%> (ø) 20260 <2> (-7) ⬇️
Impacted Files Coverage Δ Complexity Δ
apps/files_external/appinfo/app.php 0% <ø> (ø) 0 <0> (ø) ⬇️
lib/base.php 4.23% <0%> (+0.01%) 153 <0> (ø) ⬇️
lib/private/Autoloader.php 92.68% <100%> (ø) 20 <2> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb4b30a...28180d8. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

X Tutup