X Tutup
Skip to content

[stable10] Adjust PHP max version comments#35752

Merged
phil-davis merged 2 commits intostable10from
stable10-support-php-73
Jul 3, 2019
Merged

[stable10] Adjust PHP max version comments#35752
phil-davis merged 2 commits intostable10from
stable10-support-php-73

Conversation

@phil-davis
Copy link
Contributor

@phil-davis phil-davis commented Jul 3, 2019

Backport of 2nd commit from #35751
And other minor string quoting changes from aaf8c03
To get the files in stable10 more similar to master

This is tidy up for issue #34464

@codecov
Copy link

codecov bot commented Jul 3, 2019

Codecov Report

Merging #35752 into stable10 will decrease coverage by 18.98%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             stable10   #35752       +/-   ##
===============================================
- Coverage       64.67%   45.68%   -18.99%     
===============================================
  Files            1300      116     -1184     
  Lines           77362    11520    -65842     
  Branches         1301     1301               
===============================================
- Hits            50034     5263    -44771     
+ Misses          26943     5872    -21071     
  Partials          385      385
Flag Coverage Δ Complexity Δ
#javascript 53.85% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 31.13% <ø> (-34.68%) 0 <ø> (-20267)
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Storage/DAV.php 59.45% <0%> (-21.64%) 0% <0%> (ø)
apps/updatenotification/templates/admin.php
lib/private/Encryption/Keys/Storage.php
lib/private/App/CodeChecker/NodeVisitor.php
lib/private/RedisFactory.php
apps/dav/lib/Avatars/AvatarNode.php
...s/dav/appinfo/Migrations/Version20170202213905.php
apps/dav/lib/Upload/ChunkLocationProvider.php
apps/files/lib/AppInfo/Application.php
apps/systemtags/list.php
... and 1173 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d704115...5587958. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 3, 2019

Codecov Report

Merging #35752 into stable10 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             stable10   #35752   +/-   ##
===========================================
  Coverage       64.94%   64.94%           
  Complexity      20267    20267           
===========================================
  Files            1300     1300           
  Lines           77362    77362           
  Branches         1301     1301           
===========================================
  Hits            50241    50241           
  Misses          26736    26736           
  Partials          385      385
Flag Coverage Δ Complexity Δ
#javascript 53.85% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.11% <ø> (ø) 20267 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
console.php 0% <ø> (ø) 0 <0> (ø) ⬇️
index.php 0% <ø> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d704115...5587958. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

X Tutup