X Tutup
Skip to content

[stable10] [OCM] Set unknown remote protocol for remote mounts to https#35711

Merged
VicDeo merged 1 commit intostable10from
stable10-fix-34633
Jul 1, 2019
Merged

[stable10] [OCM] Set unknown remote protocol for remote mounts to https#35711
VicDeo merged 1 commit intostable10from
stable10-fix-34633

Conversation

@VicDeo
Copy link
Member

@VicDeo VicDeo commented Jul 1, 2019

Description

Otherwise the external storage and cache will fail

Related Issue

Motivation and Context

Not working external storage when the resource was shared from user@host instead of user@proto://host

How Has This Been Tested?

by stripping protocol for the remote in oc_share_external table

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@VicDeo VicDeo added this to the development milestone Jul 1, 2019
@VicDeo VicDeo self-assigned this Jul 1, 2019
@VicDeo VicDeo mentioned this pull request Jul 1, 2019
Merged
11 tasks
@codecov
Copy link

codecov bot commented Jul 1, 2019

Codecov Report

Merging #35711 into stable10 will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #35711      +/-   ##
==============================================
- Coverage        64.9%    64.9%   -0.01%     
+ Complexity      20229    20225       -4     
==============================================
  Files            1294     1294              
  Lines           77250    77253       +3     
  Branches         1301     1301              
==============================================
- Hits            50141    50140       -1     
- Misses          26724    26728       +4     
  Partials          385      385
Flag Coverage Δ Complexity Δ
#javascript 53.85% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.06% <100%> (-0.01%) 20225 <0> (-4)
Impacted Files Coverage Δ Complexity Δ
apps/files_sharing/lib/External/MountProvider.php 100% <100%> (ø) 5 <0> (+1) ⬆️
apps/files/lib/Command/VerifyChecksums.php 91.76% <0%> (-4.67%) 32% <0%> (-5%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c408e35...c1e0845. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jul 1, 2019 •
edited
Loading

Codecov Report

Merging #35711 into stable10 will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #35711      +/-   ##
==============================================
- Coverage        64.9%    64.9%   -0.01%     
+ Complexity      20229    20225       -4     
==============================================
  Files            1294     1294              
  Lines           77250    77253       +3     
  Branches         1301     1301              
==============================================
- Hits            50141    50140       -1     
- Misses          26724    26728       +4     
  Partials          385      385
Flag Coverage Δ Complexity Δ
#javascript 53.85% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 66.06% <100%> (-0.01%) 20225 <0> (-4)
Impacted Files Coverage Δ Complexity Δ
apps/files_sharing/lib/External/MountProvider.php 100% <100%> (ø) 5 <0> (+1) ⬆️
apps/files/lib/Command/VerifyChecksums.php 91.76% <0%> (-4.67%) 32% <0%> (-5%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c408e35...c1e0845. Read the comment docs.

@VicDeo VicDeo merged commit 38f7682 into stable10 Jul 1, 2019
@delete-merged-branch delete-merged-branch bot deleted the stable10-fix-34633 branch July 1, 2019 19:10
@davitol davitol mentioned this pull request Sep 3, 2019
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phil-davis phil-davis phil-davis approved these changes

Assignees

@VicDeo VicDeo

Labels

4 - To release

Projects

None yet

Milestone

development

Development

Successfully merging this pull request may close these issues.

3 participants

@VicDeo @phil-davis @patrickjahns
X Tutup