[stable10] Backport of Fix path option in the verify checksum cmd#35694
Merged
[stable10] Backport of Fix path option in the verify checksum cmd#35694
Conversation
Member
|
Code looks fine, but CI seems to be in a rebelious phase... |
Contributor
The path option in the verify checksum command should now be relative to the user folder. Signed-off-by: Sujith H <sharidasan@owncloud.com>
sharidas
force-pushed
the
fix-path-verify-checksum-stable10
branch
from
684d3b6 to
2f7d772
Compare
Codecov Report
@@ Coverage Diff @@
## stable10 #35694 +/- ##
==============================================
- Coverage 64.86% 64.85% -0.01%
+ Complexity 20225 20220 -5
==============================================
Files 1294 1294
Lines 77279 77280 +1
Branches 1301 1301
==============================================
- Hits 50126 50123 -3
- Misses 26768 26772 +4
Partials 385 385
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## stable10 #35694 +/- ##
==============================================
- Coverage 64.86% 64.85% -0.01%
+ Complexity 20225 20220 -5
==============================================
Files 1294 1294
Lines 77279 77280 +1
Branches 1301 1301
==============================================
- Hits 50126 50123 -3
- Misses 26768 26772 +4
Partials 385 385
Continue to review full report at Codecov.
|
11 tasks
Contributor
Author
|
Original PR: #35483 |
jvillafanez
approved these changes
Jul 1, 2019
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The path option in the verify checksum command
should now be relative to the user folder.
Signed-off-by: Sujith H sharidasan@owncloud.com
Description
The verify checksum command was failing to fix the checksum when path option is provided as:
$user/files/fooor/$user/files/foo/barThe reason for this is
get()in the https://github.com/owncloud/core/blob/master/lib/private/Files/Node/Root.php#L180 will add extra entry in the cache. This PR tries to resolve the issue by accepting path which is relative to users folder, instead of datadirectory.Related Issue
Motivation and Context
This PR solves the addition of the file path to the filecache table, when -p option is used with the command.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: