X Tutup
Skip to content

[10.2.1] if user has enough permission, allow to increase permission#35633

Merged
micbar merged 1 commit intorelease-10.2.1from
release-10.2.1-fix-35528
Jun 24, 2019
Merged

[10.2.1] if user has enough permission, allow to increase permission#35633
micbar merged 1 commit intorelease-10.2.1from
release-10.2.1-fix-35528

Conversation

@patrickjahns
Copy link
Contributor

@patrickjahns patrickjahns commented Jun 24, 2019

Description

Backport of #35614

Related Issue

#35528

Motivation and Context

Have the fix in 10.2.1 release

How Has This Been Tested?

  • needs careful testing during QA phase of 10.2.1

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

⛔️

@patrickjahns patrickjahns added this to the QA milestone Jun 24, 2019
@patrickjahns patrickjahns self-assigned this Jun 24, 2019
karakayasemi
karakayasemi approved these changes Jun 24, 2019
View reviewed changes
Copy link
Contributor

@karakayasemi karakayasemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

phil-davis
phil-davis reviewed Jun 24, 2019
View reviewed changes
@karakayasemi @patrickjahns
if user has enough permission, allow to increase permission
5a528dc 
Signed-off-by: Patrick Jahns <github@patrickjahns.de>
@patrickjahns patrickjahns force-pushed the release-10.2.1-fix-35528 branch from 0a8a0c5 to 5a528dc Compare June 24, 2019 11:22
@micbar micbar merged commit 2ad9aa6 into release-10.2.1 Jun 24, 2019
@delete-merged-branch delete-merged-branch bot deleted the release-10.2.1-fix-35528 branch June 24, 2019 15:25
@phil-davis phil-davis mentioned this pull request Jun 25, 2019
Merged
11 tasks
@davitol davitol mentioned this pull request Jun 25, 2019
Closed
11 tasks
@patrickjahns patrickjahns modified the milestone: QA Jun 27, 2019
@phil-davis phil-davis mentioned this pull request Aug 2, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@phil-davis phil-davis phil-davis left review comments

@DeepDiver1975 DeepDiver1975 Awaiting requested review from DeepDiver1975

@micbar micbar Awaiting requested review from micbar

+1 more reviewer

@karakayasemi karakayasemi karakayasemi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@patrickjahns patrickjahns

Labels

3 - To Review

Projects

None yet

Milestone

10.2.1

Development

Successfully merging this pull request may close these issues.

4 participants

@patrickjahns @phil-davis @karakayasemi @micbar
X Tutup