[stable10] Backport of Accessing sharetab directly for a long list of files#35306
Merged
[stable10] Backport of Accessing sharetab directly for a long list of files#35306
Conversation
… files Accessing sharetab directly for a long list of files caused problems. The pages need to be fetched appropriately to get the data. This changeset fixes the problem. Signed-off-by: Sujith H <sharidasan@owncloud.com>
sharidas
changed the title
sharidas
force-pushed
the
add-new-exception-objstorage-stable10
branch
from
82a6f64 to
d41946d
Compare
jvillafanez
approved these changes
May 22, 2019
Codecov Report
@@ Coverage Diff @@
## stable10 #35306 +/- ##
===========================================
Coverage 64.64% 64.64%
Complexity 20089 20089
===========================================
Files 1289 1289
Lines 76943 76943
Branches 1300 1300
===========================================
Hits 49738 49738
Misses 26821 26821
Partials 384 384
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## stable10 #35306 +/- ##
===========================================
Coverage 64.64% 64.64%
Complexity 20089 20089
===========================================
Files 1289 1289
Lines 76943 76943
Branches 1300 1300
===========================================
Hits 49738 49738
Misses 26821 26821
Partials 384 384
Continue to review full report at Codecov.
|
delete-merged-branch
bot
deleted the
add-new-exception-objstorage-stable10
branch
10 tasks
Contributor
|
Original PR in |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accessing sharetab directly for a long list of
files caused problems. The pages need to be fetched
appropriately to get the data. This changeset fixes
the problem.
Signed-off-by: Sujith H sharidasan@owncloud.com
Description
Lets say we have 30 files listed in the the UI. The maximum page size we have is 18. And hence when user tries to access the 19th file from the UI using
http://localhost/testing2/index.php/apps/files/?dir=/test&&scrollto=file19.txt&details=shareTabView( wherefile19.txt) is the 19th file in the list, then the sharetab would be shown without any details. The reason for this is its the 19th element and hence the filelist doesn't have thetradded. So to solve this issue, the index of the file from thethis.filesis taken. And this would help to calculate the number of attempts required to fetch the page so that we get the data.Related Issue
Motivation and Context
We need to fetch the pages to get the data populated, so that when they are accessed for the share tab field, the tab does not show empty.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: