[10.2.0] Backport of The public link edit template was outside public upload check#35238
Merged
PVince81 merged 1 commit intorelease-10.2.0from May 15, 2019
Merged
Conversation
… upload check The public link edit template was outside public upload check. And hence for creating the public link for files the full permission option was shown. This change tries to address the issue. Signed-off-by: Sujith H <sharidasan@owncloud.com>
sharidas
force-pushed
the
fix-public-link-view-issue-release-10.2.0
branch
from
39d4749 to
4cbc7f4
Compare
sharidas
changed the title
Contributor
Author
|
Original PR #35226 |
This was referenced May 15, 2019
Codecov Report
@@ Coverage Diff @@
## release-10.2.0 #35238 +/- ##
====================================================
+ Coverage 64.39% 64.39% +<.01%
Complexity 20051 20051
====================================================
Files 1285 1285
Lines 76846 76846
Branches 1308 1308
====================================================
+ Hits 49484 49485 +1
+ Misses 26978 26977 -1
Partials 384 384
Continue to review full report at Codecov.
|
2 similar comments
Codecov Report
@@ Coverage Diff @@
## release-10.2.0 #35238 +/- ##
====================================================
+ Coverage 64.39% 64.39% +<.01%
Complexity 20051 20051
====================================================
Files 1285 1285
Lines 76846 76846
Branches 1308 1308
====================================================
+ Hits 49484 49485 +1
+ Misses 26978 26977 -1
Partials 384 384
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## release-10.2.0 #35238 +/- ##
====================================================
+ Coverage 64.39% 64.39% +<.01%
Complexity 20051 20051
====================================================
Files 1285 1285
Lines 76846 76846
Branches 1308 1308
====================================================
+ Hits 49484 49485 +1
+ Misses 26978 26977 -1
Partials 384 384
Continue to review full report at Codecov.
|
delete-merged-branch
bot
deleted the
fix-public-link-view-issue-release-10.2.0
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The public link edit template was outside public upload check.
And hence for creating the public link for files the full
permission option was shown. This change tries to address
the issue.
Signed-off-by: Sujith H sharidasan@owncloud.com
Description
The
Download / View / Editoption was outside the check for variablepublicUploadPossiblein the template. And this caused the issue for files. When user tries to create the public links for files theDownload / View / Editoption is visible. But when user clicks it only view permission is available for the public link created. So in this change set theDownload / View / Editoption is added inside thepublicUploadPossiblecheck and hence the consistency is brought back for creating public links for files.Related Issue
Motivation and Context
The
Download / View / Editoption was moved out of thepublicUploadPossiblecheck in the template. Hence there caused inconistency when the public links for files created.How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: