X Tutup
Skip to content

[10.2.0] Backport of Fix permission and update behaviour for public link#35197

Merged
PVince81 merged 1 commit intorelease-10.2.0from
update-permission-and-behaviour-release-10.2.0
May 10, 2019
Merged

[10.2.0] Backport of Fix permission and update behaviour for public link#35197
PVince81 merged 1 commit intorelease-10.2.0from
update-permission-and-behaviour-release-10.2.0

Conversation

@sharidas
Copy link
Contributor

@sharidas sharidas commented May 10, 2019

Remove update permission for Download/View/Upload
option for public link. And hence the behaviour of
public links created using this option has changed.

  1. User cannot delete the files/folders inside this public link.
  2. User cannot update the files which are already present
    in the public link
  3. User cannot rename files.

Signed-off-by: Sujith H sharidasan@owncloud.com

Description

This PR addresses the changes below:
When user selects the Download / View / Upload option to create public link, the update permission for the link is no longer available. Which means the share permission will be 5 ( i.e, READ | CREATE ). And due to this change, the public link UI behaves as follows:
When a public link share is created for a folder with permission Download / View / Upload below are the changes observed:

  • Cannot delete the files.
  • Folders can be renamed. For details kindly look into the original PR Fix permission and update behaviour for public link #35194 where the discussion happened.
  • Files and Folders can be downloaded.
  • Folders with same name cannot be created.
  • Files with same name when uploaded throws notification message in the UI.
  • There is a difference with the original PR. That is tests/acceptance/features/apiShareManagementBasic/createShare.feature is not available in the release-10.2.0 branch. Hence I have removed the change in this PR.

Related Issue

Motivation and Context

Updated the permission for the Download / View / Upload option to create public link. Accordingly minor changes to update the UI.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@sharidas sharidas added this to the development milestone May 10, 2019
@sharidas sharidas requested a review from PVince81 May 10, 2019 08:13
@sharidas sharidas self-assigned this May 10, 2019
@sharidas
Copy link
Contributor Author

sharidas commented May 10, 2019

Original PR: #35194

@sharidas sharidas mentioned this pull request May 10, 2019
Merged
21 tasks
@sharidas
[10.2.0] Backport of Fix permission and update behaviour for public link
d588b4a 
Remove update permission for Download/View/Upload
option for public link. And hence the behaviour of
public links created using this option has changed.
1. User cannot delete the files/folders inside this public link.
2. User cannot update the files which are already present
in the public link
3. User cannot rename files.

Signed-off-by: Sujith H <sharidasan@owncloud.com>
@sharidas sharidas force-pushed the update-permission-and-behaviour-release-10.2.0 branch from 3aac394 to d588b4a Compare May 10, 2019 08:58
@codecov
Copy link

codecov bot commented May 10, 2019

Codecov Report

Merging #35197 into release-10.2.0 will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@                 Coverage Diff                  @@
##             release-10.2.0   #35197      +/-   ##
====================================================
- Coverage             64.39%   64.39%   -0.01%     
- Complexity            20048    20049       +1     
====================================================
  Files                  1285     1285              
  Lines                 76841    76842       +1     
  Branches               1308     1308              
====================================================
  Hits                  49480    49480              
- Misses                26977    26978       +1     
  Partials                384      384
Flag Coverage Δ Complexity Δ
#javascript 53.66% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.53% <100%> (-0.01%) 20049 <0> (+1)
Impacted Files Coverage Δ Complexity Δ
core/js/sharedialoglinkshareview.js 83.46% <ø> (ø) 0 <0> (ø) ⬇️
...es_sharing/lib/Controller/Share20OcsController.php 87.56% <100%> (+0.02%) 202 <0> (+1) ⬆️
lib/private/Server.php 86.54% <0%> (-0.12%) 253% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6237fae...d588b4a. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented May 10, 2019 •
edited
Loading

Codecov Report

Merging #35197 into release-10.2.0 will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@                 Coverage Diff                  @@
##             release-10.2.0   #35197      +/-   ##
====================================================
- Coverage             64.39%   64.39%   -0.01%     
- Complexity            20048    20049       +1     
====================================================
  Files                  1285     1285              
  Lines                 76841    76842       +1     
  Branches               1308     1308              
====================================================
  Hits                  49480    49480              
- Misses                26977    26978       +1     
  Partials                384      384
Flag Coverage Δ Complexity Δ
#javascript 53.66% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.53% <100%> (-0.01%) 20049 <0> (+1)
Impacted Files Coverage Δ Complexity Δ
core/js/sharedialoglinkshareview.js 83.46% <ø> (ø) 0 <0> (ø) ⬇️
...es_sharing/lib/Controller/Share20OcsController.php 87.56% <100%> (+0.02%) 202 <0> (+1) ⬆️
lib/private/Server.php 86.54% <0%> (-0.12%) 253% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6237fae...d588b4a. Read the comment docs.

PVince81
PVince81 approved these changes May 10, 2019
View reviewed changes
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit 6551672 into release-10.2.0 May 10, 2019
@delete-merged-branch delete-merged-branch bot deleted the update-permission-and-behaviour-release-10.2.0 branch May 10, 2019 11:27
@patrickjahns patrickjahns modified the milestones: development, QA May 15, 2019
@patrickjahns
Copy link
Contributor

patrickjahns commented May 15, 2019

Set milestone to QA to reflect that this belonged to the release

@lock lock bot locked as resolved and limited conversation to collaborators May 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@PVince81 PVince81 PVince81 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sharidas sharidas

Labels

4 - To release

Projects

None yet

Milestone

10.2.0

Development

Successfully merging this pull request may close these issues.

3 participants

@sharidas @patrickjahns @PVince81
X Tutup