[stable10] Have a real controller handling cron requests#34932
[stable10] Have a real controller handling cron requests#34932DeepDiver1975 merged 3 commits intostable10from
Conversation
|
the logger change was needed only because cron.php was what I call a "naked PHP file". now that the logic is streamlined within the app framework, exceptions should already be properly caught there, so no need to add this change @phil-davis ready for review then ? |
phil-davis
force-pushed
the
stable10-tech-dept/json.php
branch
from
e0a536b to
a351f5c
Compare
Codecov Report
@@ Coverage Diff @@
## stable10 #34932 +/- ##
==============================================
+ Coverage 64.21% 64.3% +0.08%
- Complexity 19908 19924 +16
==============================================
Files 1277 1279 +2
Lines 76365 76284 -81
Branches 1292 1292
==============================================
+ Hits 49036 49052 +16
+ Misses 26950 26853 -97
Partials 379 379
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## stable10 #34932 +/- ##
==============================================
+ Coverage 64.94% 65.02% +0.07%
- Complexity 20260 20279 +19
==============================================
Files 1300 1302 +2
Lines 77346 77353 +7
Branches 1301 1301
==============================================
+ Hits 50236 50296 +60
+ Misses 26725 26672 -53
Partials 385 385
Continue to review full report at Codecov.
|
|
Rebased to get a new run of CI and investigate why some unit tests are failing. |
phil-davis
force-pushed
the
stable10-tech-dept/json.php
branch
from
a351f5c to
e8820ca
Compare
phil-davis
force-pushed
the
stable10-tech-dept/json.php
branch
from
e8820ca to
061b04b
Compare
phil-davis
force-pushed
the
stable10-tech-dept/json.php
branch
from
061b04b to
26651a3
Compare
phil-davis
force-pushed
the
stable10-tech-dept/json.php
branch
from
26651a3 to
df7fc1b
Compare
phil-davis
force-pushed
the
stable10-tech-dept/json.php
branch
from
3c34330 to
64b1887
Compare
|
@DeepDiver1975 @PVince81 I'm not sure why I left this here so long. It works fine, just needed that last commit to remove the PHP7.1+ This is another bit of crud to get Ready for review. |
4 participants
Backport #31914
The last commit removes some PHP7.1-only
: voidreturn declarations so that the unit tests pass here instable10with PHP 7.0.Note: since the PR in master,
cron.phpwas modified by PR #32404 - that PR changed some exception logging https://github.com/owncloud/core/pull/32404/filesI did not see where to apply a similar "fix" to this new code with- see comment below, this is OK.CronController. I think there is nothing needed. But someone please confirm that while reviewing.