X Tutup
Skip to content

[stable10] allow user to configure automatically accept incoming shares#34647

Merged
PVince81 merged 1 commit intostable10from
backport-34593
Mar 1, 2019
Merged

[stable10] allow user to configure automatically accept incoming shares#34647
PVince81 merged 1 commit intostable10from
backport-34593

Conversation

@karakayasemi
Copy link
Contributor

@karakayasemi karakayasemi commented Feb 28, 2019

Backport of #34593

Description

Let the users decide whether they want to manually accept shares or not.

Related Issue

Motivation and Context

some users will not want that shares are accepted automatically.

How Has This Been Tested?

Unit tests are added. Manually tested.

  • When global auto_accept_share enabled, go Sharing Personal Panel and disable auto accept share, the next share should be on the pending status.
  • When global auto_accept_share enabled, go Sharing Personal Panel and enableauto accept share, the next share should be accepted automatically.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@karakayasemi karakayasemi self-assigned this Feb 28, 2019
@codecov
Copy link

codecov bot commented Feb 28, 2019

Codecov Report

Merging #34647 into stable10 will increase coverage by 0.02%.
The diff coverage is 98.43%.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #34647      +/-   ##
==============================================
+ Coverage       63.98%   64.01%   +0.02%     
- Complexity      19227    19246      +19     
==============================================
  Files            1272     1276       +4     
  Lines           75724    75787      +63     
  Branches         1291     1291              
==============================================
+ Hits            48453    48515      +62     
- Misses          26892    26893       +1     
  Partials          379      379
Flag Coverage Δ Complexity Δ
#javascript 53.22% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.16% <98.43%> (+0.03%) 19246 <19> (+19) ⬆️
Impacted Files Coverage Δ Complexity Δ
apps/files_sharing/appinfo/routes.php 98.5% <ø> (ø) 0 <0> (ø) ⬇️
apps/files_sharing/lib/API/Share20OCS.php 93.48% <100%> (+0.01%) 184 <0> (ø) ⬇️
...iles_sharing/lib/Panels/Personal/PersonalPanel.php 100% <100%> (ø) 4 <4> (?)
apps/files_sharing/lib/Panels/Personal/Section.php 100% <100%> (ø) 5 <5> (?)
...ring/lib/Controller/PersonalSettingsController.php 100% <100%> (ø) 10 <10> (?)
apps/files_sharing/templates/settings-personal.php 66.66% <66.66%> (ø) 0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d55f2b1...d812d21. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Feb 28, 2019 •
edited
Loading

Codecov Report

Merging #34647 into stable10 will increase coverage by 0.02%.
The diff coverage is 98.43%.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #34647      +/-   ##
==============================================
+ Coverage       63.98%   64.01%   +0.02%     
- Complexity      19227    19246      +19     
==============================================
  Files            1272     1276       +4     
  Lines           75724    75787      +63     
  Branches         1291     1291              
==============================================
+ Hits            48453    48515      +62     
- Misses          26892    26893       +1     
  Partials          379      379
Flag Coverage Δ Complexity Δ
#javascript 53.22% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.16% <98.43%> (+0.03%) 19246 <19> (+19) ⬆️
Impacted Files Coverage Δ Complexity Δ
apps/files_sharing/appinfo/routes.php 98.5% <ø> (ø) 0 <0> (ø) ⬇️
apps/files_sharing/lib/API/Share20OCS.php 93.48% <100%> (+0.01%) 184 <0> (ø) ⬇️
...iles_sharing/lib/Panels/Personal/PersonalPanel.php 100% <100%> (ø) 4 <4> (?)
apps/files_sharing/lib/Panels/Personal/Section.php 100% <100%> (ø) 5 <5> (?)
...ring/lib/Controller/PersonalSettingsController.php 100% <100%> (ø) 10 <10> (?)
apps/files_sharing/templates/settings-personal.php 66.66% <66.66%> (ø) 0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d55f2b1...d812d21. Read the comment docs.

PVince81
PVince81 approved these changes Mar 1, 2019
View reviewed changes
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 merged commit bbf7316 into stable10 Mar 1, 2019
@PVince81 PVince81 deleted the backport-34593 branch March 1, 2019 09:08
@phil-davis phil-davis mentioned this pull request Mar 9, 2019
Merged
11 tasks
@PVince81 PVince81 added this to the QA milestone Apr 12, 2019
This was referenced Apr 15, 2019
Closed
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jvillafanez jvillafanez Awaiting requested review from jvillafanez

1 more reviewer

@PVince81 PVince81 PVince81 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@karakayasemi karakayasemi

Labels

3 - To Review

Projects

None yet

Milestone

10.2.0

Development

Successfully merging this pull request may close these issues.

2 participants

@karakayasemi @PVince81
X Tutup