X Tutup
Skip to content

[stable10] Bump @bower_components/jsTimezoneDetect from 1.0.5 to v1.0.6 in /build#33776

Merged
DeepDiver1975 merged 1 commit intostable10from
dependabot/npm_and_yarn/build/stable10/@bower_components/jsTimezoneDetect-v1.0.6
Jul 30, 2019
Merged

[stable10] Bump @bower_components/jsTimezoneDetect from 1.0.5 to v1.0.6 in /build#33776
DeepDiver1975 merged 1 commit intostable10from
dependabot/npm_and_yarn/build/stable10/@bower_components/jsTimezoneDetect-v1.0.6

Conversation

@dependabot-preview
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Dec 5, 2018 •
edited
Loading

Bumps @bower_components/jsTimezoneDetect from 1.0.5 to v1.0.6.

Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/build/stable10/@bower_components/jsTimezoneDetect-v1.0.6 branch from 53db5ed to 9f46fdb Compare December 5, 2018 15:44
@PVince81
Copy link
Contributor

PVince81 commented Dec 5, 2018

UTC -> Etc/UTC

depending how we are storing the timezone in the config, not sure if it will get recognized

@codecov
Copy link

codecov bot commented Dec 5, 2018

Codecov Report

Merging #33776 into stable10 will increase coverage by 0.29%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #33776      +/-   ##
==============================================
+ Coverage       62.89%   63.18%   +0.29%     
  Complexity      19080    19080              
==============================================
  Files            1261     1261              
  Lines           74977    74977              
  Branches         1286     1286              
==============================================
+ Hits            47157    47376     +219     
+ Misses          27440    27221     -219     
  Partials          380      380
Flag Coverage Δ Complexity Δ
#javascript 53.19% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 64.26% <ø> (+0.32%) 19080 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
apps/files_external/lib/Lib/Storage/Swift.php 66.16% <0%> (+66.16%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61e757f...9f46fdb. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Dec 5, 2018

Codecov Report

Merging #33776 into stable10 will increase coverage by 0.29%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #33776      +/-   ##
==============================================
+ Coverage       62.89%   63.18%   +0.29%     
  Complexity      19080    19080              
==============================================
  Files            1261     1261              
  Lines           74977    74977              
  Branches         1286     1286              
==============================================
+ Hits            47157    47376     +219     
+ Misses          27440    27221     -219     
  Partials          380      380
Flag Coverage Δ Complexity Δ
#javascript 53.19% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 64.26% <ø> (+0.32%) 19080 <ø> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
apps/files_external/lib/Lib/Storage/Swift.php 66.16% <0%> (+66.16%) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61e757f...9f46fdb. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 5, 2018 •
edited
Loading

Codecov Report

Merging #33776 into stable10 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             stable10   #33776   +/-   ##
===========================================
  Coverage       64.23%   64.23%           
  Complexity      19901    19901           
===========================================
  Files            1277     1277           
  Lines           76270    76270           
  Branches         1292     1292           
===========================================
  Hits            48992    48992           
  Misses          26899    26899           
  Partials          379      379
Flag Coverage Δ Complexity Δ
#javascript 53.2% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.4% <ø> (ø) 19901 <ø> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c52530...448807d. Read the comment docs.

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/build/stable10/@bower_components/jsTimezoneDetect-v1.0.6 branch from 9f46fdb to 54b54bf Compare December 13, 2018 15:55
@phil-davis
Copy link
Contributor

phil-davis commented Dec 19, 2018

@dependabot rebase

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/build/stable10/@bower_components/jsTimezoneDetect-v1.0.6 branch from 54b54bf to c65e005 Compare December 19, 2018 03:17
@DeepDiver1975 DeepDiver1975 changed the title Bump @bower_components/jsTimezoneDetect from 1.0.5 to v1.0.6 in /build [stable10] Bump @bower_components/jsTimezoneDetect from 1.0.5 to v1.0.6 in /build Jan 7, 2019
@PVince81 PVince81 added this to the development milestone Feb 8, 2019
@PVince81
Copy link
Contributor

PVince81 commented Feb 8, 2019

@davitol please test logging in with "UTC" timezone before and after this PR and check that oc_preferences store the right value.

now I don't remember where this timezone value is even used where we could verify @DeepDiver1975

@PVince81
Copy link
Contributor

PVince81 commented Feb 8, 2019

oc_preferences will now likely store Etc/UTC instead of UTC.

@PVince81
Copy link
Contributor

PVince81 commented Feb 8, 2019

if this is too much work we can simply deny the upgrade and reconsider later...

@davitol
Copy link
Contributor

davitol commented Feb 12, 2019 •
edited
Loading

oc_preferences will now likely store Etc/UTC instead of UTC.

@PVince81 This is what appears in oc_preferences using this PR. Not sure about the purpose of the PR.

select * from oc_preferences;
+--------+-------+-----------+---------------+
| userid | appid | configkey | configvalue |
+--------+-------+-----------+---------------+
| admin | core | timezone | Europe/Berlin |
+--------+-------+-----------+---------------+
1 row in set (0.00 sec)

@PVince81
Copy link
Contributor

PVince81 commented Feb 12, 2019

hmmm, so not sure if it's possible to set the system timezone or browser timezone to UTC?

@davitol
Copy link
Contributor

davitol commented Feb 12, 2019

hmmm, so not sure if it's possible to set the system timezone or browser timezone to UTC?

It is possible for example for the logs: occ log:manage --timezone=UTC

But I don't get the point about setting a Timezone for "the complete server"?

oc_preferences table is related to each user so it is not also an option for that.

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/build/stable10/@bower_components/jsTimezoneDetect-v1.0.6 branch from c65e005 to 3395fb1 Compare February 25, 2019 16:56
@phil-davis
Copy link
Contributor

phil-davis commented Mar 20, 2019

@dependabot recreate

@dependabot-support
Bump @bower_components/jsTimezoneDetect from 1.0.5 to v1.0.6 in /build
448807d 
Bumps [@bower_components/jsTimezoneDetect](https://github.com/HenningM/jstimezonedetect) from 1.0.5 to v1.0.6.
- [Release notes](https://github.com/HenningM/jstimezonedetect/releases)
- [Commits](HenningM/jstimezonedetect@2efb16c...bd595ed)

Signed-off-by: dependabot[bot] <support@dependabot.com>
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/build/stable10/@bower_components/jsTimezoneDetect-v1.0.6 branch from 3395fb1 to 448807d Compare March 20, 2019 12:07
@phil-davis
Copy link
Contributor

phil-davis commented Mar 24, 2019

matching PR in master is #33319 which was merged back in 2018.
what to do here for stable10 ?

@DeepDiver1975 DeepDiver1975 merged commit eca2e63 into stable10 Jul 30, 2019
@delete-merged-branch delete-merged-branch bot deleted the dependabot/npm_and_yarn/build/stable10/@bower_components/jsTimezoneDetect-v1.0.6 branch July 30, 2019 06:24
@davitol davitol mentioned this pull request Sep 3, 2019
Closed
13 tasks
@individual-it
Copy link
Member

individual-it commented Sep 12, 2019

this is about the timezone on the client. When setting the timezone on the client to UTC sudo timedatectl set-timezone UTC and logging in a new user in oc_preferences oC 10.2.1 will set the time to UTC and 10.3.0 (after this PR) to Etc/UTC

@individual-it
Copy link
Member

individual-it commented Sep 12, 2019

after upgrade it first stays UTC then after a new login it gets changed to Etc/UTC

I've made a short smoke-test with the calendar app and could not find any issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@davitol davitol

Labels

3 - To Review dependencies javascript

Projects

None yet

Milestone

development

Development

Successfully merging this pull request may close these issues.

7 participants

@PVince81 @phil-davis @davitol @individual-it @DeepDiver1975 @patrickjahns @dependabot-support
X Tutup