All committers have signed the CLA.

fixes #26941

@siteshpattanaik001 Please fill the template as much as possible. This will help the reviewers and QA, and also it will help to understand why ownCloud should include your change. Thanks.

@siteshpattanaik001 I guess you're Sitesh from IRC ? Great to see you managed to send the PR 😄

@DeepDiver1975 @PhilippSchaffrath @IljaN can you guys confirm that gethostname() is enough here ?

I'm also wondering if there is a risk that this would reveal internal server names to the outside @Peter-Prochaska

@PVince81 Why do we have status.php? Is it useful to populate the version string to all unauthenticated users and for what case do we need the hostname?

I'll play the "bad guy" role this time....

• For small servers (only one ownCloud server), this is useless. You know where you're connecting to "mycloud.mycompany.com" so there is no need anyone tells you "you're connecting to mycould.mycompany.com" or any other internal name.
• For servers behind load balancers (I'm not an ops guy so maybe "clustered environments" are the same), this is also useless because ideally you have no idea what server you're going to fall into. Your status call can be done to "cloud01", but the next call could be done to "cloud02".
• I think there is a notion of "sticky sessions" in load balancers where all the requests your client does through the load balancer goes to the same server. THIS is where the PR might be useful and @siteshpattanaik001 this is what you should be selling! 😄

Does it make sense to make this conditional since this seems to be useful for such environments? Kind of "enable this at your own risk".

+1 for making this feature conditional. Default = false. And we should update the documentation that this feature should only be available from internal devices.

@siteshpattanaik001 can you make this conditional ?

Add a new value for config.php (and config.sample.php) that defaults to false.
When true, add that info to status.php

I guess, we don't need a config value. Just ripping off the domain of a server will be enough:
$servername = gethostname();
$position = strpos($servername, '.');
if ($position === false) {
$servershortname = $servername;
} else {
$servershortname = substr($servername, 0, $position);
}

and later....
'servername'=>$servershortname,

@GrendelWWU I'd rather not to expose unneeded information. This could be useful to debug big installations, and as such a config switch is fine.

I understand, that exposing these information can be problematic for some installations. (known bugs in oc version x.y.z, ohh! what a shame, can lead to attacks)
I don't want to work with switches in the config to switch this or that on or off.... too complicated.
Next proposal: put a format-string with variables like $servershortname, $servername, $serverversion, $owncloudversion, $maintenance in the config file. So any admin can decide, which information to reveal in status.php.

Note that we can't change the format because clients are relying on this. ownCloud is using json because clients can easily parse it: easy to use for the server, easy to parse in the client.

At most, instead of individual switches we could provide a key in the config file to know what switchable components you want to be "on".

'status.components' => ['this', 'that', 'this_too']

The "problem" with this is that we only have one component (this new one) that can be there, and I don't think will add more in the near future.

Ok, I didn't know, that the clients are examining status.php. I really thought about obfuscating some information (like oc version) via config.php or another mechanism. Know I think, this will be a very bad idea.
To make clear, why I need some more info via status.php... We're running an own themed owncloud at three locations, each on about 14 webservers with thousands of active users. When users are experiencing trouble, we can communicate with them, ask them to use status.php when ce-creating the problem. So, we know, which server logs to examine. Fortunately our balancers are really "sticky"...

Values in status.php moved into a method, see PR #27238.
Just add the change there

Any update ?

closing due to lack of activity. If anyone wants to pick it up feel free to reopen or submit another PR

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.