X Tutup
Skip to content

PublicFiles: Quote ETag in headers as well#36080

Merged
PVince81 merged 1 commit intomasterfrom
bugfix/quote-etag-in-header-public-files
Aug 29, 2019
Merged

PublicFiles: Quote ETag in headers as well#36080
PVince81 merged 1 commit intomasterfrom
bugfix/quote-etag-in-header-public-files

Conversation

@DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented Aug 22, 2019 •
edited
Loading

Description

Missing piece as of #36053

Related Issue

How Has This Been Tested?

  • ✋ with owncloud-sdk test suite

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@DeepDiver1975 DeepDiver1975 requested a review from PVince81 August 22, 2019 15:07
@DeepDiver1975 DeepDiver1975 self-assigned this Aug 22, 2019
@DeepDiver1975
Copy link
Member Author

DeepDiver1975 commented Aug 22, 2019

@individual-it it might be of interest to assess the etag header on put within the acceptance tests ....

PVince81
PVince81 approved these changes Aug 22, 2019
View reviewed changes
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81
Copy link
Contributor

PVince81 commented Aug 22, 2019

I guess this wouldn't be covered by litmus tests ?

@DeepDiver1975 DeepDiver1975 mentioned this pull request Aug 22, 2019
Closed
@phil-davis
Copy link
Contributor

phil-davis commented Aug 23, 2019

Stupid drone https://drone.owncloud.com/owncloud/core/20346/66/5

behat-chrome-webUIPersonalSettings: Error response from daemon: Get https://registry-1.docker.io/v2/mailhog/mailhog/manifests/latest: net/http: TLS handshake timeout

I restarted the build.

@individual-it individual-it self-assigned this Aug 23, 2019
@PVince81
Copy link
Contributor

PVince81 commented Aug 26, 2019

@ownclouders rebase

@PVince81 PVince81 force-pushed the bugfix/quote-etag-in-header-public-files branch from f644d97 to 2aeb598 Compare August 26, 2019 13:41
@codecov
Copy link

codecov bot commented Aug 26, 2019

Codecov Report

Merging #36080 into master will decrease coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #36080      +/-   ##
==========================================
- Coverage      54%   53.85%   -0.15%     
==========================================
  Files          63       63              
  Lines        7403     7377      -26     
  Branches     1308     1301       -7     
==========================================
- Hits         3998     3973      -25     
  Misses       3019     3019              
+ Partials      386      385       -1
Flag Coverage Δ
#javascript 53.85% <ø> (-0.15%) ⬇️
Impacted Files Coverage Δ
core/js/shareitemmodel.js 80% <0%> (-0.93%) ⬇️
core/js/sharedialogshareelistview.js 80.48% <0%> (-0.66%) ⬇️
core/js/sharedialogmailview.js 62.37% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 266dfc7...2aeb598. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 26, 2019 •
edited
Loading

Codecov Report

Merging #36080 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #36080   +/-   ##
=======================================
  Coverage      54%      54%           
=======================================
  Files          63       63           
  Lines        7403     7403           
  Branches     1308     1308           
=======================================
  Hits         3998     3998           
  Misses       3019     3019           
  Partials      386      386
Flag Coverage Δ
#javascript 54% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 266dfc7...2aeb598. Read the comment docs.

@PVince81
Copy link
Contributor

PVince81 commented Aug 26, 2019

rebased manually

@individual-it
Copy link
Member

individual-it commented Aug 29, 2019

CI failed with yarn-install problems, restarted

@PVince81 PVince81 merged commit f9c0a38 into master Aug 29, 2019
@delete-merged-branch delete-merged-branch bot deleted the bugfix/quote-etag-in-header-public-files branch August 29, 2019 09:09
This was referenced Aug 29, 2019
Open
Merged
@individual-it
Copy link
Member

individual-it commented Aug 29, 2019

tests added in #36116
one place found where the quotes are still missing #36115

@davitol davitol mentioned this pull request Sep 3, 2019
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@PVince81 PVince81 PVince81 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@DeepDiver1975 DeepDiver1975

@individual-it individual-it

Labels

3 - To Review QA:team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DeepDiver1975 @PVince81 @phil-davis @individual-it
X Tutup