X Tutup
Skip to content

Handle no longer existing resource of a link share#36066

Merged
individual-it merged 2 commits intomasterfrom
bugfix/36055
Aug 26, 2019
Merged

Handle no longer existing resource of a link share#36066
individual-it merged 2 commits intomasterfrom
bugfix/36055

Conversation

@DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented Aug 20, 2019 •
edited
Loading

Description

Handle NotFound exception properly

Related Issue

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@DeepDiver1975 DeepDiver1975 self-assigned this Aug 20, 2019
@codecov
Copy link

codecov bot commented Aug 20, 2019

Codecov Report

Merging #36066 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #36066   +/-   ##
=======================================
  Coverage   53.85%   53.85%           
=======================================
  Files          63       63           
  Lines        7377     7377           
  Branches     1301     1301           
=======================================
  Hits         3973     3973           
  Misses       3019     3019           
  Partials      385      385
Flag Coverage Δ
#javascript 53.85% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93dfcef...a8f72f0. Read the comment docs.

@codecov
Copy link

codecov bot commented Aug 20, 2019 •
edited
Loading

Codecov Report

Merging #36066 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #36066   +/-   ##
=======================================
  Coverage      54%      54%           
=======================================
  Files          63       63           
  Lines        7403     7403           
  Branches     1307     1307           
=======================================
  Hits         3998     3998           
  Misses       3019     3019           
  Partials      386      386
Flag Coverage Δ
#javascript 54% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86fd9ed...a735004. Read the comment docs.

@individual-it
Copy link
Member

individual-it commented Aug 21, 2019

@DeepDiver1975 this does not fix #36005, linked the wrong issue?

@PVince81
Copy link
Contributor

PVince81 commented Aug 23, 2019

@individual-it seems he updated the top post, please check again

PVince81
PVince81 approved these changes Aug 23, 2019
View reviewed changes
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 code looks fine

@PVince81
Copy link
Contributor

PVince81 commented Aug 23, 2019

waiting for @individual-it to confirm and merge

individual-it
individual-it approved these changes Aug 23, 2019
View reviewed changes
Copy link
Member

@individual-it individual-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a test, rebased the branch and fixed the commit message

@individual-it individual-it merged commit 2c12163 into master Aug 26, 2019
@delete-merged-branch delete-merged-branch bot deleted the bugfix/36055 branch August 26, 2019 04:25
@davitol davitol mentioned this pull request Sep 3, 2019
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@individual-it individual-it individual-it approved these changes

+1 more reviewer

@PVince81 PVince81 PVince81 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@DeepDiver1975 DeepDiver1975

Labels

3 - To Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

accessing a public link of a deleted folder via new public link webdav API results in error 500

3 participants

@DeepDiver1975 @individual-it @PVince81
X Tutup