Conversation
jvillafanez
approved these changes
Aug 19, 2019
Member
Author
|
Note: |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Always use an absolute path to app.php
Motivation and Context
outdated
appname/appinfo/app.phpcould be loaded if there are two versions of the same app in app directoriesHow Has This Been Tested?
appsis non-writable,apps-externalis writableappsintoapps-external, increase version inapps-external/appname/appinfo/app.phpapps/appname/appinfo/app.phpandapps-external/appname/appinfo/app.phpor add logging to both filesExpected
breakpoint or logging is triggered in
apps-external/appname/appinfo/app.phpas it has more recent versionActual
breakpoint or logging is triggered in
apps/appname/appinfo/app.phpTypes of changes
Checklist: