X Tutup
Skip to content

ETag has to be surrounded by double quotes#36053

Merged
DeepDiver1975 merged 1 commit intomasterfrom
bugfix/etag-trashbin-and-public-files
Aug 19, 2019
Merged

ETag has to be surrounded by double quotes#36053
DeepDiver1975 merged 1 commit intomasterfrom
bugfix/etag-trashbin-and-public-files

Conversation

@DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented Aug 16, 2019

Description

As per spec ETag has to be surrounded by double quotes.
Changed all relevant implementations and added tests

Related Issue

How Has This Been Tested?

  • 🤖

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@phil-davis
Copy link
Contributor

Silly JS test error https://drone.owncloud.com/owncloud/core/20233/5/1
I restarted the drone CI build.

@codecov
Copy link

codecov bot commented Aug 16, 2019

Codecov Report

Merging #36053 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #36053   +/-   ##
=======================================
  Coverage   53.85%   53.85%           
=======================================
  Files          63       63           
  Lines        7377     7377           
  Branches     1301     1301           
=======================================
  Hits         3973     3973           
  Misses       3019     3019           
  Partials      385      385
Flag Coverage Δ
#javascript 53.85% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9606d8f...9a3c037. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Aug 16, 2019

Codecov Report

Merging #36053 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #36053   +/-   ##
=======================================
  Coverage   53.85%   53.85%           
=======================================
  Files          63       63           
  Lines        7377     7377           
  Branches     1301     1301           
=======================================
  Hits         3973     3973           
  Misses       3019     3019           
  Partials      385      385
Flag Coverage Δ
#javascript 53.85% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9606d8f...9a3c037. Read the comment docs.

Copy link
Member

@individual-it individual-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but probably you mean it fixes #36034
#35407 seems to be unrelated

@DeepDiver1975 DeepDiver1975 merged commit 10715e2 into master Aug 19, 2019
@delete-merged-branch delete-merged-branch bot deleted the bugfix/etag-trashbin-and-public-files branch August 19, 2019 07:14
@davitol davitol mentioned this pull request Sep 3, 2019
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

trashbin webdav API does not put double quotes around etag new public link webdav API does not put double quotes around etag

3 participants

X Tutup