X Tutup
Skip to content

fix file creation with content in public webdav api#36049

Merged
DeepDiver1975 merged 1 commit intomasterfrom
fixPublicWebdavCreateFile
Aug 16, 2019
Merged

fix file creation with content in public webdav api#36049
DeepDiver1975 merged 1 commit intomasterfrom
fixPublicWebdavCreateFile

Conversation

@individual-it
Copy link
Member

@individual-it individual-it commented Aug 16, 2019

Description

write the correct content to the file

Related Issue

Motivation and Context

we want to write the data that was received into the file

How Has This Been Tested?

PUT to the webdav endpoint and check the content

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • Backport (if applicable set "backport-request" label and remove when the backport was done)

@individual-it individual-it self-assigned this Aug 16, 2019
@individual-it
Copy link
Member Author

individual-it commented Aug 16, 2019

@DeepDiver1975 I cannot find unit tests for that class, are there any?

@codecov
Copy link

codecov bot commented Aug 16, 2019

Codecov Report

Merging #36049 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #36049   +/-   ##
=======================================
  Coverage   53.85%   53.85%           
=======================================
  Files          63       63           
  Lines        7377     7377           
  Branches     1301     1301           
=======================================
  Hits         3973     3973           
  Misses       3019     3019           
  Partials      385      385
Flag Coverage Δ
#javascript 53.85% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 071924d...bc11bca. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Aug 16, 2019

Codecov Report

Merging #36049 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #36049   +/-   ##
=======================================
  Coverage   53.85%   53.85%           
=======================================
  Files          63       63           
  Lines        7377     7377           
  Branches     1301     1301           
=======================================
  Hits         3973     3973           
  Misses       3019     3019           
  Partials      385      385
Flag Coverage Δ
#javascript 53.85% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 071924d...bc11bca. Read the comment docs.

@DeepDiver1975 DeepDiver1975 merged commit 0c97276 into master Aug 16, 2019
@delete-merged-branch delete-merged-branch bot deleted the fixPublicWebdavCreateFile branch August 16, 2019 12:27
@davitol davitol mentioned this pull request Sep 3, 2019
Closed
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DeepDiver1975 DeepDiver1975 DeepDiver1975 approved these changes

Assignees

@individual-it individual-it

Labels

3 - To Review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

creating a file with the new public webdav API makes the content of the file always be "data"

2 participants

@individual-it @DeepDiver1975
X Tutup