I'm not able to run properly the acceptance tests in order to fix the error in the tests:

    Given user "user1" from server "LOCAL" has shared "/PARENT" with user "user0" from server "REMOTE"                    # FederationContext::userFromServerHasSharedWithUserFromServer()
      Could not share file/folder! message: "cURL error 60: SSL certificate problem: self signed certificate"
      Failed asserting that two strings are equal.
      --- Expected
      +++ Actual
      @@ @@
      -'100'
      +'403'

Although https is available, tests should already be configured to run through http, so this ssl problem shouldn't happen.

The problem seems to be around https://github.com/owncloud/core/blob/master/apps/federatedfilesharing/lib/Notifications.php#L323 , where the method always prioritize https. Note that the "shareWith" user has explicit http protocol ("user0@http://server/")

Codecov Report

Merging #36029 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #36029   +/-   ##
=======================================
  Coverage   53.85%   53.85%           
=======================================
  Files          63       63           
  Lines        7377     7377           
  Branches     1301     1301           
=======================================
  Hits         3973     3973           
  Misses       3019     3019           
  Partials      385      385

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c23088...098ea19. Read the comment docs.

Codecov Report

Merging #36029 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #36029   +/-   ##
=======================================
  Coverage   53.85%   53.85%           
=======================================
  Files          63       63           
  Lines        7377     7377           
  Branches     1301     1301           
=======================================
  Hits         3973     3973           
  Misses       3019     3019           
  Partials      385      385

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7407170...b5745d8. Read the comment docs.

Opened #36035 for the ssl problem. Meanwhile, I've changed https://github.com/owncloud/core/blob/master/apps/federatedfilesharing/lib/Notifications.php#L325 to use http instead in my local environment. Tests should pass now.

This is ready to review. Maybe @VicDeo can check my changes. There are quite a bunch of things that I don't like, but I just focused on making the tests pass. Any change aiming to improve the code is welcomed.

@jvillafanez looks good. Should we squash the history?

@jvillafanez looks good. Should we squash the history?

Up to you.

squashed