X Tutup
Skip to content

[stable10] Directly honour robots.txt if htaccess.RewriteBase#34949

Merged
PVince81 merged 1 commit intoowncloud:stable10from
benrubson:robots
Apr 2, 2019
Merged

[stable10] Directly honour robots.txt if htaccess.RewriteBase#34949
PVince81 merged 1 commit intoowncloud:stable10from
benrubson:robots

Conversation

@benrubson
Copy link
Contributor

@benrubson benrubson commented Apr 2, 2019

Hi,

This PR to stable10 follows PR #31483 which has just been merged into master.

Thank you 👍

@benrubson benrubson mentioned this pull request Apr 2, 2019
Merged
PVince81
PVince81 approved these changes Apr 2, 2019
View reviewed changes
Copy link
Contributor

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81 PVince81 added this to the development milestone Apr 2, 2019
@PVince81 PVince81 self-assigned this Apr 2, 2019
@codecov
Copy link

codecov bot commented Apr 2, 2019

Codecov Report

Merging #34949 into stable10 will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #34949      +/-   ##
==============================================
+ Coverage       64.21%   64.21%   +<.01%     
  Complexity      19908    19908              
==============================================
  Files            1277     1277              
  Lines           76365    76366       +1     
  Branches         1292     1292              
==============================================
+ Hits            49036    49037       +1     
  Misses          26950    26950              
  Partials          379      379
Flag Coverage Δ Complexity Δ
#javascript 53.2% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.37% <0%> (ø) 19908 <0> (ø) ⬇️
Impacted Files Coverage Δ Complexity Δ
lib/private/Setup.php 24.78% <0%> (-0.11%) 57 <0> (ø)
apps/files_trashbin/lib/Expiration.php 98.27% <0%> (+1.72%) 29% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de6ab95...9a07ea0. Read the comment docs.

@PVince81 PVince81 merged commit 245096b into owncloud:stable10 Apr 2, 2019
@benrubson
Copy link
Contributor Author

benrubson commented Apr 2, 2019

Many thx @PVince81 👍

@benrubson benrubson deleted the robots branch April 2, 2019 13:41
@PVince81 PVince81 modified the milestones: development, QA Apr 12, 2019
This was referenced Apr 15, 2019
Closed
Closed
@skshetry skshetry mentioned this pull request May 13, 2019
Closed
@skshetry skshetry mentioned this pull request May 21, 2019
Merged
11 tasks
@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@PVince81 PVince81 PVince81 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@PVince81 PVince81

Labels

4 - To release

Projects

None yet

Milestone

10.2.0

Development

Successfully merging this pull request may close these issues.

2 participants

@benrubson @PVince81
X Tutup