X Tutup
Skip to content

[stable10] allow admins to enable medial search on group and user#34779

Merged
karakayasemi merged 1 commit intostable10from
backport-medial-search
Mar 18, 2019
Merged

[stable10] allow admins to enable medial search on group and user#34779
karakayasemi merged 1 commit intostable10from
backport-medial-search

Conversation

@karakayasemi
Copy link
Contributor

@karakayasemi karakayasemi commented Mar 15, 2019

Backport of #34659

Description

allow admin to enable medial search on group and user

Related Issue

Fixes #33883 and https://github.com/owncloud/enterprise/issues/2311

Motivation and Context

we have accounts.enable_medial_search but we should move to one option respected globally for users, and one for groups, making the results more consistent.

How Has This Been Tested?

  • Create a group with "test" gid,
  • add 'groups.enable_medial_search' => true line to config
  • Sharing search dialog should list "test" group when you write "es"
  • change config as 'groups.enable_medial_search' => false
  • Sharing search dialog should not list "test" group when you write "es"

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Database schema changes (next release will require increase of minor version instead of patch)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@karakayasemi karakayasemi self-assigned this Mar 15, 2019
@codecov
Copy link

codecov bot commented Mar 15, 2019 •
edited
Loading

Codecov Report

Merging #34779 into stable10 will increase coverage by <.01%.
The diff coverage is 91.66%.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #34779      +/-   ##
==============================================
+ Coverage        64.2%    64.2%   +<.01%     
- Complexity      19883    19885       +2     
==============================================
  Files            1278     1278              
  Lines           76246    76256      +10     
  Branches         1291     1291              
==============================================
+ Hits            48950    48959       +9     
- Misses          26917    26918       +1     
  Partials          379      379
Flag Coverage Δ Complexity Δ
#javascript 53.22% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.36% <91.66%> (ø) 19885 <1> (+2) ⬆️
Impacted Files Coverage Δ Complexity Δ
lib/private/Group/Database.php 97.72% <91.66%> (-0.64%) 26 <1> (+2)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99798da...4acb527. Read the comment docs.

@karakayasemi karakayasemi merged commit 487394d into stable10 Mar 18, 2019
@delete-merged-branch delete-merged-branch bot deleted the backport-medial-search branch March 18, 2019 10:27
@PVince81 PVince81 added this to the QA milestone Apr 12, 2019
This was referenced Apr 15, 2019
Closed
Closed
@haribhandari07 haribhandari07 mentioned this pull request May 6, 2019
Merged
11 tasks
@skshetry skshetry mentioned this pull request May 13, 2019
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jvillafanez jvillafanez jvillafanez approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

Assignees

@karakayasemi karakayasemi

Labels

3 - To Review

Projects

None yet

Milestone

10.2.0

Development

Successfully merging this pull request may close these issues.

4 participants

@karakayasemi @jvillafanez @PVince81 @phil-davis
X Tutup