[stable10] Test email verification with international email address - fixes #13586#34759
Merged
phil-davis merged 1 commit intostable10from Mar 13, 2019
Merged
Conversation
9 tasks
phil-davis
approved these changes
Mar 13, 2019
Contributor
phil-davis
left a comment
phil-davis
left a comment
There was a problem hiding this comment.
And a bonus - on PHP 7.* those function return type declarations should work.
Codecov Report
@@ Coverage Diff @@
## stable10 #34759 +/- ##
==============================================
+ Coverage 63.92% 64.19% +0.27%
Complexity 19883 19883
==============================================
Files 1278 1278
Lines 76237 76237
Branches 1291 1291
==============================================
+ Hits 48735 48942 +207
+ Misses 27123 26916 -207
Partials 379 379
Continue to review full report at Codecov.
|
2 similar comments
Codecov Report
@@ Coverage Diff @@
## stable10 #34759 +/- ##
==============================================
+ Coverage 63.92% 64.19% +0.27%
Complexity 19883 19883
==============================================
Files 1278 1278
Lines 76237 76237
Branches 1291 1291
==============================================
+ Hits 48735 48942 +207
+ Misses 27123 26916 -207
Partials 379 379
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## stable10 #34759 +/- ##
==============================================
+ Coverage 63.92% 64.19% +0.27%
Complexity 19883 19883
==============================================
Files 1278 1278
Lines 76237 76237
Branches 1291 1291
==============================================
+ Hits 48735 48942 +207
+ Misses 27123 26916 -207
Partials 379 379
Continue to review full report at Codecov.
|
delete-merged-branch
bot
deleted the
stable10-test-email-verification-intl
branch
This was referenced Apr 15, 2019
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #33207 to stable10
Now possible thanks to swiftmailer update in #34755