X Tutup
Skip to content

[stable10] Throw exception in stream_read() if attempting to read the same node multiple times#34558

Merged
PVince81 merged 1 commit intostable10from
stable10-assemblystream-infinite-loop
Feb 20, 2019
Merged

[stable10] Throw exception in stream_read() if attempting to read the same node multiple times#34558
PVince81 merged 1 commit intostable10from
stable10-assemblystream-infinite-loop

Conversation

@PVince81
Copy link
Contributor

@PVince81 PVince81 commented Feb 19, 2019

Backport of #34489 to stable10

@mdusher
Throw exception in stream_read() if attempting to read the same node …
351a506 
…multiple times

Removed extra log information, doesn't work as expected

Fix comments

Add missing declaration for use Sabre\DAV\Exception\BadRequest;
@PVince81 PVince81 added this to the development milestone Feb 19, 2019
@PVince81 PVince81 self-assigned this Feb 19, 2019
@PVince81 PVince81 mentioned this pull request Feb 19, 2019
Merged
10 tasks
@codecov
Copy link

codecov bot commented Feb 19, 2019

Codecov Report

Merging #34558 into stable10 will decrease coverage by <.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #34558      +/-   ##
==============================================
- Coverage       63.93%   63.92%   -0.01%     
- Complexity      19146    19153       +7     
==============================================
  Files            1269     1269              
  Lines           75553    75566      +13     
  Branches         1293     1293              
==============================================
+ Hits            48302    48309       +7     
- Misses          26870    26876       +6     
  Partials          381      381
Flag Coverage Δ Complexity Δ
#javascript 53.29% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.06% <66.66%> (-0.01%) 19153 <0> (+7)
Impacted Files Coverage Δ Complexity Δ
apps/dav/lib/Upload/AssemblyStream.php 75.28% <66.66%> (-0.63%) 34 <0> (+3)
...pps/dav/lib/SystemTag/SystemTagsByIdCollection.php 81.03% <0%> (-5.25%) 25% <0%> (+4%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b707221...351a506. Read the comment docs.

2 similar comments
@codecov
Copy link

codecov bot commented Feb 19, 2019

Codecov Report

Merging #34558 into stable10 will decrease coverage by <.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #34558      +/-   ##
==============================================
- Coverage       63.93%   63.92%   -0.01%     
- Complexity      19146    19153       +7     
==============================================
  Files            1269     1269              
  Lines           75553    75566      +13     
  Branches         1293     1293              
==============================================
+ Hits            48302    48309       +7     
- Misses          26870    26876       +6     
  Partials          381      381
Flag Coverage Δ Complexity Δ
#javascript 53.29% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.06% <66.66%> (-0.01%) 19153 <0> (+7)
Impacted Files Coverage Δ Complexity Δ
apps/dav/lib/Upload/AssemblyStream.php 75.28% <66.66%> (-0.63%) 34 <0> (+3)
...pps/dav/lib/SystemTag/SystemTagsByIdCollection.php 81.03% <0%> (-5.25%) 25% <0%> (+4%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b707221...351a506. Read the comment docs.

@codecov
Copy link

codecov bot commented Feb 19, 2019 •
edited
Loading

Codecov Report

Merging #34558 into stable10 will decrease coverage by <.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@              Coverage Diff               @@
##             stable10   #34558      +/-   ##
==============================================
- Coverage       63.93%   63.92%   -0.01%     
- Complexity      19146    19153       +7     
==============================================
  Files            1269     1269              
  Lines           75553    75566      +13     
  Branches         1293     1293              
==============================================
+ Hits            48302    48309       +7     
- Misses          26870    26876       +6     
  Partials          381      381
Flag Coverage Δ Complexity Δ
#javascript 53.29% <ø> (ø) 0 <ø> (ø) ⬇️
#phpunit 65.06% <66.66%> (-0.01%) 19153 <0> (+7)
Impacted Files Coverage Δ Complexity Δ
apps/dav/lib/Upload/AssemblyStream.php 75.28% <66.66%> (-0.63%) 34 <0> (+3)
...pps/dav/lib/SystemTag/SystemTagsByIdCollection.php 81.03% <0%> (-5.25%) 25% <0%> (+4%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b707221...351a506. Read the comment docs.

@PVince81 PVince81 merged commit ed17412 into stable10 Feb 20, 2019
@delete-merged-branch delete-merged-branch bot deleted the stable10-assemblystream-infinite-loop branch February 20, 2019 10:37
@PVince81 PVince81 modified the milestones: development, QA Apr 12, 2019
This was referenced Apr 15, 2019
Closed
Closed
@skshetry skshetry mentioned this pull request May 13, 2019
Closed
@lock lock bot locked as resolved and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@VicDeo VicDeo Awaiting requested review from VicDeo

@DeepDiver1975 DeepDiver1975 Awaiting requested review from DeepDiver1975

@jvillafanez jvillafanez Awaiting requested review from jvillafanez

1 more reviewer

@IljaN IljaN IljaN approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@PVince81 PVince81

Labels

3 - To Review

Projects

None yet

Milestone

10.2.0

Development

Successfully merging this pull request may close these issues.

3 participants

@PVince81 @IljaN @mdusher
X Tutup