X Tutup
Skip to content

kill RemoveOldShares#27737

Merged
PVince81 merged 1 commit intomasterfrom
kill-oc90-repair-steps
May 4, 2017
Merged

kill RemoveOldShares#27737
PVince81 merged 1 commit intomasterfrom
kill-oc90-repair-steps

Conversation

@DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented Apr 24, 2017 •
edited
Loading

Description

💀

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@DeepDiver1975 DeepDiver1975 added this to the 10.0 milestone Apr 24, 2017
@DeepDiver1975 DeepDiver1975 requested a review from PVince81 April 24, 2017 21:06
@PVince81 PVince81 modified the milestones: 10.0.1, 10.0 Apr 25, 2017
@PVince81
Copy link
Contributor

PVince81 commented Apr 25, 2017

10.0.1. Only criticals from now on.

JS tests timed out.

@PVince81
Copy link
Contributor

PVince81 commented Apr 25, 2017

👍

To merge after 10.0.0 is out.

DeepDiver1975
DeepDiver1975 commented Apr 26, 2017
View reviewed changes
Copy link
Member Author

@DeepDiver1975 DeepDiver1975 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Printing out the log before behat execution?

@SergioBertolinSG
Copy link
Contributor

SergioBertolinSG commented Apr 27, 2017

Removed last commits, they were just for debugging. Being addressed here #27749

This PR will require a rebase after that one is fixed in master.

@PVince81 PVince81 force-pushed the kill-oc90-repair-steps branch from 9d43aa3 to 27cc10b Compare May 4, 2017 05:05
@PVince81
Copy link
Contributor

PVince81 commented May 4, 2017

Rebased for CI

@PVince81 PVince81 merged commit 7ceef9c into master May 4, 2017
@PVince81 PVince81 deleted the kill-oc90-repair-steps branch May 4, 2017 09:26
@lock
Copy link

lock bot commented Aug 3, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Aug 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@PVince81 PVince81 Awaiting requested review from PVince81

Assignees

No one assigned

Labels

3 - To Review

Projects

None yet

Milestone

10.0.1

Development

Successfully merging this pull request may close these issues.

3 participants

@DeepDiver1975 @PVince81 @SergioBertolinSG
X Tutup