Remove sharing subtab headers if no link share is allowed#27708
Merged
DeepDiver1975 merged 1 commit intomasterfrom May 4, 2017
Merged
Remove sharing subtab headers if no link share is allowed#27708DeepDiver1975 merged 1 commit intomasterfrom
DeepDiver1975 merged 1 commit intomasterfrom
Conversation
Because then there is only one tab to select, so only keep its body.
PVince81
force-pushed
the
share-nolink-removesubtab
branch
from
fbb1254 to
64852b2
Compare
Contributor
Author
|
Tested as follows:
@felixheidecke @tomneedham @VicDeo please review |
DeepDiver1975
approved these changes
May 4, 2017
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Because then there is only one tab to select, so only keep its body.
Related Issue
None (I thought there was one but can't find it any more)
Motivation and Context
It looks bad to have an empty "Public link" subtab.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
@felixheidecke please review