Remove FillETags repair-step. (#40996)

IljaN · web-flow · commit bda6b692ad1e · 2023-09-26T13:27:08.000+02:00
* Remove FillETags repair-step.

* Fix test

* changelog
diff --git a/changelog/unreleased/40996 b/changelog/unreleased/40996
@@ -0,0 +1,6 @@
+Enhancement: Remove "Fill E-Tags" Repair-Step
+
+This legacy repair-step took very long to run during an upgrade of a large system and
+didn't repair anything anymore.
+
+https://github.com/owncloud/core/pull/40996
diff --git a/lib/private/Repair.php b/lib/private/Repair.php
@@ -43,7 +43,6 @@
 use OC\Repair\SharePropagation;
 use OC\Repair\SqliteAutoincrement;
 use OC\Repair\DropOldTables;
-use OC\Repair\FillETags;
 use OC\Repair\InnoDB;
 use OC\Repair\RepairMimeTypes;
 use OC\Repair\SearchLuceneTables;
@@ -134,7 +133,6 @@ public static function getRepairSteps() {
 				\OC::$server->getLogger(),
 				\OC::$server->getConfig()
 			),
-			new FillETags(\OC::$server->getDatabaseConnection()),
 			new CleanTags(\OC::$server->getDatabaseConnection(), \OC::$server->getUserManager()),
 			new DropOldTables(\OC::$server->getDatabaseConnection()),
 			new DropOldJobs(\OC::$server->getJobList()),
diff --git a/lib/private/Repair/FillETags.php b/lib/private/Repair/FillETags.php
diff --git a/tests/acceptance/features/cliMain/maintenance.feature b/tests/acceptance/features/cliMain/maintenance.feature
@@ -9,12 +9,11 @@ Feature: Maintenance command
   Scenario: Repair steps should be listed correctly
     When the administrator list the repair steps using the occ command
     Then the command should have been successful
-    And the command output should contain the text "Found 17 repair steps"
+    And the command output should contain the text "Found 16 repair steps"
     And the command output table should contain the following text:
       | table_column                          |
       | OC\Repair\RepairMimeTypes             |
       | OC\Repair\RepairMismatchFileCachePath |
-      | OC\Repair\FillETags                   |
       | OC\Repair\CleanTags                   |
       | OC\Repair\DropOldTables               |
       | OC\Repair\DropOldJobs                 |
