Add UI acceptance test for Username on Personal General Settings page

phil-davis · phil-davis · commit af5bb04c032f · 2023-01-31T10:48:03.000+05:45
diff --git a/tests/acceptance/features/bootstrap/WebUIPersonalGeneralSettingsContext.php b/tests/acceptance/features/bootstrap/WebUIPersonalGeneralSettingsContext.php
@@ -286,6 +286,22 @@ public function groupShouldBeDisplayedOnThePersonalGeneralSettingsPageOnTheWebui
 		);
 	}
 
+	/**
+	 * @Then username :userName should be displayed on the personal general settings page on the webUI
+	 *
+	 * @param string $userName
+	 *
+	 * @return void
+	 */
+	public function usernameShouldBeDisplayedOnThePersonalGeneralSettingsPageOnTheWebui(string $userName):void {
+		Assert::assertEquals(
+			$userName,
+			$this->personalGeneralSettingsPage->getUsername(),
+			__METHOD__
+			. " Username '$userName' is not displayed on the personal general settings page on the webUI."
+		);
+	}
+
 	/**
 	 * @When the user follows the email change confirmation link received by :emailAddress using the webUI
 	 * @Given the user has followed the email change confirmation link received by :emailAddress using the webUI
diff --git a/tests/acceptance/features/lib/PersonalGeneralSettingsPage.php b/tests/acceptance/features/lib/PersonalGeneralSettingsPage.php
@@ -50,6 +50,7 @@ class PersonalGeneralSettingsPage extends OwncloudPage {
 
 	protected $versionSectionXpath = "//div[@id='OC\\Settings\\Panels\\Personal\\Version']";
 	protected $federatedCloudIDXpath = "//*[@id='fileSharingSettings']/p/strong";
+	protected $usernameXpath = "//div[@id='OC\\Settings\\Panels\\Personal\\Profile']/div[@id='username']";
 	protected $groupListXpath = "//div[@id='OC\\Settings\\Panels\\Personal\\Profile']/div[@id='groups']";
 
 	protected $setProfilePicFromFilesBtnXpath = "//*[@id='selectavatar']";
@@ -200,6 +201,18 @@ public function getFederatedCloudID(): string {
 		return $this->find("xpath", $this->federatedCloudIDXpath)->getText();
 	}
 
+	/**
+	 * get username displayed in the UI
+	 *
+	 * @return string
+	 */
+	public function getUsername(): string {
+		$this->waitTillElementIsNotNull($this->usernameXpath);
+		// The text is like "Username Alice"
+		$text = $this->find("xpath", $this->usernameXpath)->getText();
+		return \substr($text, \strlen("Username "));
+	}
+
 	/**
 	 * check if a group with given name is displayed in the UI
 	 *
diff --git a/tests/acceptance/features/webUIPersonalSettings/personalGeneralSettings.feature b/tests/acceptance/features/webUIPersonalSettings/personalGeneralSettings.feature
@@ -35,6 +35,13 @@ Feature: personal general settings
     And group "new-group" should be displayed on the personal general settings page on the webUI
     And group "another-group" should be displayed on the personal general settings page on the webUI
 
+  @skipOnOcV10.11 @skipOnOcV10.10
+  Scenario: user sees their username displayed on the personal general settings page
+    Given the administrator has changed the display name of user "Alice" to "New display name"
+    And the user has reloaded the current page of the webUI
+    Then "New display name" should be shown as the name of the current user on the webUI
+    And username "Alice" should be displayed on the personal general settings page on the webUI
+
 
   Scenario: User sets profile picture from their existing cloud file
     Given user "Alice" has uploaded file "filesForUpload/testavatar.jpg" to "/testimage.jpg"
