extend share_external name column length to 255

karakayasemi · karakayasemi · commit 9614d641a3cb · 2020-08-23T06:21:44.000-07:00
diff --git a/apps/files_sharing/appinfo/Migrations/Version20200823121322.php b/apps/files_sharing/appinfo/Migrations/Version20200823121322.php
@@ -0,0 +1,40 @@
+<?php
+/**
+ * @author Semih Serhat Karakaya <karakayasemi@itu.edu.tr>
+ *
+ * @copyright Copyright (c) 2020, ownCloud GmbH
+ * @license AGPL-3.0
+ *
+ * This code is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License, version 3,
+ * as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License, version 3,
+ * along with this program.  If not, see <http://www.gnu.org/licenses/>
+ *
+ */
+namespace OCA\Files_Sharing\Migrations;
+
+use Doctrine\DBAL\Schema\Schema;
+use OCP\Migration\ISchemaMigration;
+
+/**
+ * Extend name column length to 255
+ */
+class Version20200823121322 implements ISchemaMigration {
+	public function changeSchema(Schema $schema, array $options) {
+		$prefix = $options['tablePrefix'];
+		if ($schema->hasTable("${prefix}share_external")) {
+			$table = $schema->getTable("{$prefix}share_external");
+			$nameColumn = $table->getColumn('name');
+			if ($nameColumn && $nameColumn->getLength() !== 255) {
+				$nameColumn->setOptions(['length' => 255]);
+			}
+		}
+	}
+}
diff --git a/apps/files_sharing/appinfo/info.xml b/apps/files_sharing/appinfo/info.xml
@@ -10,7 +10,7 @@ Turning the feature off removes shared files and folders on the server for all s
 	<licence>AGPL</licence>
 	<author>Michael Gapczynski, Bjoern Schiessle</author>
 	<default_enable/>
-	<version>0.13.0</version>
+	<version>0.13.1</version>
 	<types>
 		<filesystem/>
 	</types>
diff --git a/changelog/unreleased/37835 b/changelog/unreleased/37835
@@ -0,0 +1,7 @@
+Bugfix: Allow federated share name up to 255 character
+
+Receiving a federated share of a file with name greater than 63 characters was not possible.
+This problem has been resolved by extending related column length of database to 255.
+
+https://github.com/owncloud/core/issues/36730
+https://github.com/owncloud/core/pull/37835
diff --git a/tests/acceptance/features/webUISharingExternal1/federationSharing.feature b/tests/acceptance/features/webUISharingExternal1/federationSharing.feature
@@ -192,17 +192,13 @@ Feature: Federation Sharing - sharing with users on other cloud storages
     And as "Brian" file "/simple-folder (2)/lorem.txt" should exist
     When the user opens folder "simple-folder (2)" using the webUI
     Then it should not be possible to delete file "lorem.txt" using the webUI
-
-  @issue-36730
+    
   Scenario: test sharing long file names with federation share
     When user "Alice" moves file "/lorem.txt" to "/averylongfilenamefortestingthatfileswithlongfilenamescannotbeshared.txt" using the WebDAV API
     And the user has reloaded the current page of the webUI
     And the user shares file "averylongfilenamefortestingthatfileswithlongfilenamescannotbeshared.txt" with remote user "Alice" with displayname "%username%@%remote_server_without_scheme%" using the webUI
-    #  And user "Alice" from server "REMOTE" accepts the last pending share using the sharing API
-    And using server "REMOTE"
-    Then user "Alice" should not have any received shares
-    # Then as "Alice" file "/averylongfilenamefortestingthatfileswithlongfilenamescannotbeshared.txt" should exist
-    Then as "Alice" file "/averylongfilenamefortestingthatfileswithlongfilenamescannotbeshared.txt" should not exist
+    And user "Alice" from server "REMOTE" accepts the last pending share using the sharing API
+    Then as "Alice" file "/averylongfilenamefortestingthatfileswithlongfilenamescannotbeshared.txt" should exist
 
   Scenario: sharee should be able to access the files/folders inside other folder
     Given user "Alice" has created folder "simple-folder/simple-empty-folder"
