fix: implement missing getSize method in SharedFile.php

David Christofas · phil-davis · commit 91e59ba5abdc · 2020-01-21T09:24:37.000+05:45
The webdav-api for public files couldn't get the correct file size since `SharedFile.php` did not implement the `getSize` method. Fixes #36741
diff --git a/apps/dav/lib/Files/PublicFiles/SharedFile.php b/apps/dav/lib/Files/PublicFiles/SharedFile.php
@@ -71,4 +71,8 @@ public function put($data) {
 			throw new Forbidden('Permission denied to change data');
 		}
 	}
+
+	public function getSize() {
+		return $this->file->getSize();
+	}
 }
diff --git a/apps/dav/tests/unit/Files/PublicFiles/PublicFileTest.php b/apps/dav/tests/unit/Files/PublicFiles/PublicFileTest.php
@@ -34,4 +34,12 @@ public function testETag() {
 		$metaFile = new SharedFile($file, $share);
 		$this->assertEquals('"123456"', $metaFile->getETag());
 	}
+
+	public function testSize() {
+		$file = $this->createMock(File::class);
+		$file->method('getSize')->willReturn(42);
+		$share = $this->createMock(IShare::class);
+		$metaFile = new SharedFile($file, $share);
+		$this->assertEquals(42, $metaFile->getSize());
+	}
 }
diff --git a/changelog/unreleased/36778 b/changelog/unreleased/36778
@@ -0,0 +1,4 @@
+Bugfix: Return correct file size in the public files webdav API
+
+https://github.com/owncloud/core/issues/36741
+https://github.com/owncloud/core/pull/36778

Original file line number	Diff line number	Diff line change
`@@ -71,4 +71,8 @@ public function put($data) {`
`71`	`71`	`throw new Forbidden('Permission denied to change data');`
`72`	`72`	`}`
`73`	`73`	`}`
	`74`	`+`
	`75`	`+ public function getSize() {`
	`76`	`+ return $this->file->getSize();`
	`77`	`+ }`
`74`	`78`	`}`
Original file line number	Diff line number	Diff line change
`@@ -34,4 +34,12 @@ public function testETag() {`
`34`	`34`	`$metaFile = new SharedFile($file, $share);`
`35`	`35`	`$this->assertEquals('"123456"', $metaFile->getETag());`
`36`	`36`	`}`
	`37`	`+`
	`38`	`+ public function testSize() {`
	`39`	`+ $file = $this->createMock(File::class);`
	`40`	`+ $file->method('getSize')->willReturn(42);`
	`41`	`+ $share = $this->createMock(IShare::class);`
	`42`	`+ $metaFile = new SharedFile($file, $share);`
	`43`	`+ $this->assertEquals(42, $metaFile->getSize());`
	`44`	`+ }`
`37`	`45`	`}`