Merge pull request #38107 from /issues/4241

Jan · web-flow · commit 7e31c836df46 · 2020-11-17T11:22:06.000+01:00
This solves the issue, while generating a public link ssl check conne…
diff --git a/apps/files_sharing/ajax/external.php b/apps/files_sharing/ajax/external.php
@@ -71,19 +71,6 @@
 		\OC::$server->getUserSession()->getUser()->getUID()
 );
 
-// check for ssl cert
-if (\substr($remote, 0, 5) === 'https') {
-	try {
-		\OC::$server->getHTTPClientService()->newClient()->get($remote, [
-			'timeout' => 10,
-			'connect_timeout' => 10,
-		])->getBody();
-	} catch (\Exception $e) {
-		\OCP\JSON::error(['data' => ['message' => $l->t('Invalid or untrusted SSL certificate')]]);
-		exit;
-	}
-}
-
 $mount = $externalManager->addShare($remote, $token, $password, $name, $ownerDisplayName, true);
 
 /**
diff --git a/changelog/unreleased/38107 b/changelog/unreleased/38107
@@ -0,0 +1,11 @@
+Bugfix: SSL check when adding a public link to your ownCloud
+
+Prior to this fix, a SSL certificate check was performed when adding a
+public link to your ownCloud. As this check was done on the base URL of the
+server, it could cause some issues, for example endless redirect loops.
+This fix gets rid of the SSL check because the storage-check afterwards
+also checks the validity of the server's SSL certificate. This check is
+being made on /status.php, thus it likely wont end up in a redirect loop.
+
+https://github.com/owncloud/enterprise/issues/4241
+https://github.com/owncloud/core/pull/38107
