Refactor to not have required parameters following an optional parameter

phil-davis · phil-davis · commit 381de901a231 · 2022-08-18T16:11:46.000+05:45
diff --git a/apps/files_sharing/lib/Controller/Share20OcsController.php b/apps/files_sharing/lib/Controller/Share20OcsController.php
@@ -621,7 +621,7 @@ public function createShare() {
 	 * [Share::SHARE_TYPE_USER => true, Share::SHARE_TYPE_GROUP => false]
 	 * @return Result
 	 */
-	private function getSharedWithMe($node = null, $includeTags, $requestedShareTypes, $stateFilter = 0) {
+	private function getSharedWithMe($node, $includeTags, $requestedShareTypes, $stateFilter = 0) {
 		// sharedWithMe is limited to user and group shares for compatibility.
 		$shares = [];
 		if (isset($requestedShareTypes[Share::SHARE_TYPE_USER]) && $requestedShareTypes[Share::SHARE_TYPE_USER]) {
diff --git a/lib/public/UserTokenException.php b/lib/public/UserTokenException.php
@@ -36,7 +36,7 @@ class UserTokenException extends \Exception {
 	 * @param \Exception|null $previous
 	 * @since 10.0.10
 	 */
-	public function __construct($message = "", $code, \Exception $previous = null) {
+	public function __construct($message = "", $code = 0, \Exception $previous = null) {
 		parent::__construct($message, $code, $previous);
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ class UserTokenException extends \Exception {`
`36`	`36`	`* @param \Exception\|null $previous`
`37`	`37`	`* @since 10.0.10`
`38`	`38`	`*/`
`39`		`- public function __construct($message = "", $code, \Exception $previous = null) {`
	`39`	`+ public function __construct($message = "", $code = 0, \Exception $previous = null) {`
`40`	`40`	`parent::__construct($message, $code, $previous);`
`41`	`41`	`}`
`42`	`42`	`}`