Tests/add disable stage tests#3045
Open
shawnmcmanus wants to merge 3 commits intoopenrocket:unstablefrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1693
Description
This is my first open source contribution, and I chose this issue because I have a personal interest in rocketry and wanted to contribute to a project I find genuinely exciting.
This PR adds deterministic unit tests for the disable-stage functionality in
BarrowmanCalculatorTest.javaandMassCalculatorTest.java, as suggested in issue #1693.The existing
DisableStageTest.javaverifies disable-stage behavior through full simulations, which can occasionally produce flaky failures due to simulation inaccuracies. The new tests avoid this by asserting on analytical outputs instead:BarrowmanCalculatorTest.testDisabledStageAerodynamics()— verifies that disabling the core and booster stages correctly reduces CNa, shifts the center of pressure forward, and that re-enabling all stages fully restores the original valuesMassCalculatorTest.testDisabledStageMassAndCG()— verifies that disabling the core and booster stages correctly reduces structural mass, produces the expected center of gravity, and that re-enabling all stages fully restores the original valuesBoth tests use the existing Falcon 9 Heavy test rocket and its established constants, so the expected values are cross-validated against the existing test suite.
Testing
All existing tests in both
BarrowmanCalculatorTest(20 tests) andMassCalculatorTest(33 tests) pass with the new additions included.