Fixed #3588 to use darwin-x64 for all node < 16.0.0#3709
Open
Rahulbeniwal26119 wants to merge 1 commit intonvm-sh:masterfrom
Open
Fixed #3588 to use darwin-x64 for all node < 16.0.0#3709Rahulbeniwal26119 wants to merge 1 commit intonvm-sh:masterfrom
Rahulbeniwal26119 wants to merge 1 commit intonvm-sh:masterfrom
Conversation
ljharb
reviewed
Nov 16, 2025
Rahulbeniwal26119
force-pushed
the
fallback-to-x64-for-darwin-node-versions-less-than-16
branch
from
951b758 to
0ff9272
Compare
ljharb
force-pushed
the
fallback-to-x64-for-darwin-node-versions-less-than-16
branch
from
0ff9272 to
3385907
Compare
Member
|
I'm still a bit unclear. You're saying that node 14.18.0 doesn't run on mac arm64, despite the existence of https://nodejs.org/dist/v14.18.0/node-v14.18.0-darwin-x64.tar.gz ? |
Rahulbeniwal26119
force-pushed
the
fallback-to-x64-for-darwin-node-versions-less-than-16
branch
from
3385907 to
433cd44
Compare
Contributor
Author
This issue for for arm based macs as less than <16 we don't have arm based tar only darwin-x64 are there so in those when we try to install v14 then expected file based on architecture (darwin-arm64) don't exists. So this pr make changes to consider arch as x64 for version less than 16 for darwin. 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue raised by #3588