X Tutup
Skip to content

crypto: read algorithm name property only once in normalizeAlgorithm#62170

Open
panva wants to merge 1 commit intonodejs:mainfrom
panva:read-name-once
Open

crypto: read algorithm name property only once in normalizeAlgorithm#62170
panva wants to merge 1 commit intonodejs:mainfrom
panva:read-name-once

Conversation

@panva
Copy link
Member

@panva panva commented Mar 9, 2026

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. labels Mar 9, 2026
@panva panva added the webcrypto label Mar 9, 2026
@nodejs-github-bot

This comment was marked as outdated.

@codecov
Copy link

codecov bot commented Mar 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.63%. Comparing base (3725bd2) to head (e5897f3).
⚠️ Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #62170      +/-   ##
==========================================
- Coverage   89.65%   89.63%   -0.02%     
==========================================
  Files         676      676              
  Lines      206543   206544       +1     
  Branches    39547    39548       +1     
==========================================
- Hits       185184   185146      -38     
- Misses      13480    13531      +51     
+ Partials     7879     7867      -12     
Files with missing lines Coverage Δ
lib/internal/crypto/util.js 95.45% <100.00%> (+0.01%) ⬆️

... and 54 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot
Copy link
Collaborator

@panva panva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. webcrypto

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

X Tutup